Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Delete crates from parity-ethereum and fetch them from parity-common instead#9083

Merged
dvdplm merged 24 commits intomasterfrom
chore/remove-crates-moved-to-parity-common
Jul 10, 2018
Merged

Delete crates from parity-ethereum and fetch them from parity-common instead#9083
dvdplm merged 24 commits intomasterfrom
chore/remove-crates-moved-to-parity-common

Conversation

@dvdplm
Copy link
Copy Markdown
Collaborator

@dvdplm dvdplm commented Jul 10, 2018 •
edited
Loading

Part 2 of issue #9011

Here the moved crates are actually removed from parity-ethereum.

Crates:

hashdb
keccak-hash
kvdb
kvdb-memorydb
kvdb-rocksdb
memorydb
parity-bytes
parity-crypto
path
patricia_trie
plain_hasher
rlp
target
test-support
trie-standardmap
triehash

Merge after #9058

dvdplm added 23 commits July 6, 2018 13:04
@dvdplm
Use crates from parity-common
5298e5b
@dvdplm
Use parity-common
6d085a2
@dvdplm
Use parity-common
fceab9d
@dvdplm
Fix extern crate and use statements for renamed crates
58d4686
@dvdplm
Merge branch 'master' into chore/use-parity-common
9b0a120 
* master:
  remove util-error (#9054)
@dvdplm
Fix Cargo.lock
abce585
@dvdplm
Merge branch 'master' into chore/use-parity-common
accc881 
* master:
  fetch: replace futures-timer with tokio-timer (#9066)
@dvdplm
Add helper crate to ease the pain of dealing with trie roots
c7c0885
@dvdplm
Add triehash-ethereum to workspace
4903024
@dvdplm
Cargo.lock updates
fe76e76
@dvdplm
Fetch triehash from git
c67fc71
@dvdplm
Use triehash-ethereum in ethcore/sync
eb666fb
@dvdplm
Fix funny indentation
f9a322b
@dvdplm
Use specific rev to force update
0227c12
@dvdplm
specific rev
965869b
@dvdplm
Use the triehash-ethereum helper crate
40e1a08 
Specific rev
@dvdplm
Use specific rev
4e258f7
@dvdplm
Load kvdb-memorydb from parity-common
7e86cda
@dvdplm
Merge branch 'master' into chore/use-parity-common
b0c25b7 
* master:
  Clean up deprecated options and add CHECK macro (#9036)
  Replace `std::env::home_dir` with `dirs::home_dir` (#9077)
  fix warning in secret-store test (#9074)
  SeedHashCompute remove needless `new` impl (#9063)
  remove trait bounds from several structs (#9055)
  docs: add changelog for 1.10.9 stable and 1.11.6 beta (#9069)
  Enable test in `miner/pool/test` (#9072)
@dvdplm
whitespace
00cfa9c
@dvdplm
Use latest version of parity common
8a89684
@dvdplm
Remove crates that now live in parity-common
09be72e
@dvdplm
Remove rev key
2cb75d3
@dvdplm dvdplm requested review from debris and niklasad1 July 10, 2018 09:14
@5chdn 5chdn added this to the 2.1 milestone Jul 10, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M5-dependencies 🖇 Dependencies. labels Jul 10, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.0 Jul 10, 2018
@debris
Copy link
Copy Markdown
Collaborator

debris commented Jul 10, 2018

tbh, I'd rather merge this one instead of #9011 :)

@dvdplm
Copy link
Copy Markdown
Collaborator Author

dvdplm commented Jul 10, 2018

tbh, I'd rather merge this one instead of #9011 :)

I don't have a strong opinion either way. I wanted to avoid causing merge conflicts for people, but maybe the shorter the agony the better?

cc/ @5chdn

@5chdn
Copy link
Copy Markdown
Contributor

5chdn commented Jul 10, 2018

I'm not sure I understand the difference between the two PRs.

@dvdplm
Copy link
Copy Markdown
Collaborator Author

dvdplm commented Jul 10, 2018

@5chdn in #9011 the moved crates are still there while in this one they are deleted.

@dvdplm
Copy link
Copy Markdown
Collaborator Author

dvdplm commented Jul 10, 2018

@debris @niklasad1 I closed #9011 in favor of this one, please add any outstanding issues here.

@debris
Copy link
Copy Markdown
Collaborator

debris commented Jul 10, 2018

let's merge this ASAP

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 10, 2018
@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. labels Jul 10, 2018
@dvdplm dvdplm merged commit c7f608e into master Jul 10, 2018
@5chdn 5chdn deleted the chore/remove-crates-moved-to-parity-common branch July 10, 2018 13:02
dvdplm added a commit that referenced this pull request Jul 10, 2018
@dvdplm
Merge branch 'master' into a5-cli-fastloose
7b765b8 
* master:
  Delete crates from parity-ethereum and fetch them from parity-common instead (#9083)
  Updater verification (#8787)
  Phrasing, precisions and typos in CLI help (#9060)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@debris debris debris approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. M5-dependencies 🖇 Dependencies. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Projects

None yet

Milestone

2.0 Ethereum

Development

Successfully merging this pull request may close these issues.

4 participants

@dvdplm @debris @5chdn @niklasad1