This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Make work-notify an optional feature#9018
Closed
udoprog wants to merge 1 commit into
Closed
Conversation
|
It looks like @udoprog hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
Contributor
Author
|
[clabot:check] |
|
It looks like @udoprog signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
5chdn
added
A0-pleasereview 🤓
Contributor
Author
|
Closing in favor of #9020 which contains all the features I want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step towards making depending on parity components a bit lighter.
I'm a bit unsure on if
Stratumis still needed at all when the work-notify feature is disabled. I think in principle yes, butwork-notifyseems to be all it is currently used for.My ultimate goal is to make depending on hyper and tokio optional when we don't need to access external services, like when testing smart contracts. Removing those two dependencies transitively would remove a large chunks of crates being compiled when depending on ethcore.