EIP-1186: add `eth_getProof` RPC-Method by simon-jentzsch · Pull Request #9001 · openethereum/parity-ethereum

simon-jentzsch · 2018-06-28T11:30:00Z

Implementation for the EIP-1186

Ethereum uses MerkleTrees to store the state of accounts and their storage. This allows verification of each value by simply creating a MerkleProof. But currently the eth-Module does not give you access to these proofs. This EIP suggests a additional RPC-Method, which creates MerkleProofs for Accounts and Storage-Values.

Combined with a stateRoot (from the blockheader) it enables offline verification of any account or storage-value. This allows especially IOT-Devices or even mobile apps which are not able to run a light client to verify responses from a untrusted source.

parity-cla-bot · 2018-06-28T11:30:03Z

It looks like @simon-jentzsch hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

5chdn · 2018-06-28T12:45:38Z

Hey, please sign our CLA.

This EIP suggests an additional RPC-Method, which creates MerkleProofs for Accounts and Storage-Values.

Which EIP are you referring to? Is this officially part of the eth namespace?

simon-jentzsch · 2018-06-28T14:59:10Z

Thanks for the responses.
This referrs to the ethereum/EIPs#1186 we just started.
I'll check the CLA und of course I'll also fix the changes we made for our docker-script.

5chdn · 2018-06-28T15:20:04Z

Ah, gotcha. I'll mark this WIP.

dvdplm · 2018-06-29T06:18:29Z

The CI failure is spurious here and should be fixed if you pull in the latest changes from master.

simon-jentzsch · 2018-06-29T10:13:38Z

[clabot:check]

parity-cla-bot · 2018-06-29T10:13:39Z

It looks like @simon-jentzsch signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

simon-jentzsch

fixed and merged master into pull-request

stale

5chdn · 2018-07-02T12:27:06Z

Putting this on ice since you have chosen the eth_ namespace. This does not allow us to adapt this until the EIP is either accepted or a majority of clients implement it. 🐧

simon-jentzsch · 2018-07-08T11:10:44Z

Thanks, Yes, I also considered using a different namespace. In the end I believe that offering the proof as a rpc-function should be part of the standard-module. That's why I choose the eth_ namespace, on the other hand it would be easier to have this function in one of the next releases, if this is a part of the parity -module. But in the long run I want all clients to support this. But I'm open for discussion. And until we get this feature in, we are using the forked-version.

5chdn · 2018-07-09T06:59:28Z

Ok, let me know how you want to proceed.

sorpaas · 2018-07-19T05:09:25Z

@simon-jentzsch We can use the parity_ namespace first and then move it to eth_ namespace once it's standardized. This is how eth_chainId/parity_chainId was dealt with (ethereum/EIPs#695).

simon-jentzsch · 2018-09-21T07:58:57Z

@sorpaas Yes, this would be an option to use the parity-namespace, but since it is also important that geth will implement it as well, I rather have it as a real standard. For now we can live with using our fork of parity. I am also maintaining Docker-Images https://hub.docker.com/r/slockit/parity-in3/tags/ which we are using. But I just hope the EIP will go through soon. ;-)

simon-jentzsch · 2018-09-21T12:20:34Z

@5chdn I created the PR for the EIP and hope that it will go through. I also merged the changes for parity 2.x and created a Docker-Container on dockerhub. So I think it would be good,if we can repopen this PR.

simon-jentzsch · 2018-10-17T22:15:50Z

@5chdn Would be good to reopen this pull request, since the EIP is now merged and a offical Draft: https://eips.ethereum.org/EIPS/eip-1186

Co-Authored-By: simon-jentzsch <simon@slock.it>

niklasad1

Looks good now, however still some formatting issues on some struct fields, should be have the format field: val

Also, would be good to have tests for this too!

Tbaut · 2018-11-08T14:49:14Z

Could you please update the doc in src/interfaces/eth.js interfaces https://github.com/parity-js/jsonrpc

simon-jentzsch · 2018-11-08T15:59:20Z

@niklasad1 I fixed the formatting of the structs and also added tests.
@Tbaut Added eth_getProof at the doc. ( See PR parity-js/jsonrpc#14 )

ordian

Looks good, thank you. I guess merging this with eth_ namespace is fine, since EIP-1186 was accepted and implemented in geth as well (cc @tomusdrw).

simon-jentzsch · 2018-11-10T08:53:49Z

Thanks, I'm looking forward to see this merged!

tomusdrw · 2018-11-17T23:50:13Z

IMHO this should be enabled only with --jsonrpc-experimental, see #9928

simon-jentzsch · 2018-11-19T14:35:35Z

tests are running again
implemented the check for the experimental RPCs flag

tomusdrw

Looks good. Left couple of minor comments that would be nice to address (but not super required).

This RPC seems a bit heavy though, I'm a bit concerned with performance here (imagine fetching a proof of the entire cryptokitties storage).

tomusdrw · 2018-11-19T15:29:29Z

+				account_proof: proof.into_iter().map(Bytes::new).collect(),
+				storage_proof: values.into_iter().filter_map(|storage_index| { 
+					let key2: H256 = storage_index.into();
+					match self.client.prove_storage(key1, keccak(key2), id) {


could be a .map instead of match

ok, changed it.

tomusdrw · 2018-11-19T15:30:34Z

 }

+#[test]
+fn eth_get_proof() {


Would be good to have a test already when experimental_rpcs are disabled.

simon-jentzsch · 2018-11-19T16:45:10Z

Yes, getting a lot of proof could be heavy, but since you can't get the entire storage without specifying all available storage keys, it is only heavy, if you pass a long list of keys.
So it may make sense for infura to limit the number of storage values, but if you are running your own node and want to get all cryptokitties, then you should know what you are doing. ( and how to calculate all storage keys )

Or to put it with gavin's words:

https://youtu.be/26ucTSSaqog?t=7448

simon-jentzsch · 2018-11-19T17:50:18Z

But concerning the performance, I think there is room for optimization here (which can be done later ).

after getting the account-proof we already have the BasicAccount-Object and so the storage_root.

But when calling the prove_storage (just like the lightclient), this function always fetches the Account-Object again before finding the storage key. And this happens for each storage key.
So it would be more efficient to get Account only once.

https://github.com/paritytech/parity-ethereum/blob/master/ethcore/src/state/mod.rs#L1203

5chdn added A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. M6-rpcapi 📣 RPC API. labels Jun 28, 2018

5chdn added this to the 1.12 milestone Jun 28, 2018

5chdn previously requested changes Jun 28, 2018

View reviewed changes

Comment thread docker/hub/Dockerfile Outdated

Comment thread ethcore/src/state/account.rs Outdated

simon-jentzsch mentioned this pull request Jun 28, 2018

EIP-1186: RPC-Method to get Merkle Proofs - eth_getProof ethereum/EIPs#1186

Closed

2 tasks

5chdn added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jun 28, 2018

5chdn changed the title ~~add eth_getProof RPC-Method~~ EIP-1186: add eth_getProof RPC-Method Jun 28, 2018

dvdplm reviewed Jun 28, 2018

View reviewed changes

Comment thread rpc/src/v1/impls/eth.rs Outdated

Comment thread rpc/src/v1/impls/eth.rs Outdated

Comment thread rpc/src/v1/impls/light/eth.rs

dvdplm reviewed Jun 28, 2018

View reviewed changes

Comment thread rpc/src/v1/types/account_info.rs Outdated

simon-jentzsch commented Jun 29, 2018

View reviewed changes

5chdn removed the A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. label Jun 29, 2018

5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 2, 2018

HarryR mentioned this pull request Jul 2, 2018

Transaction and event proofs against ethereum block headers HarryR/panautomata#6

Open

5chdn closed this Jul 9, 2018

5chdn reopened this Oct 18, 2018

niklasad1 and others added 5 commits November 6, 2018 07:06

fixed format

0c6c8a9

Co-Authored-By: simon-jentzsch <simon@slock.it>

fixed empty lines

972c4c2

Merge branch 'in3' of github.com:slockit/parity into in3

6f67a42

removed Option from EthAccount

fa05357

fixed storage_index

4db8cec

niklasad1 approved these changes Nov 8, 2018

View reviewed changes

niklasad1 added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 8, 2018

implemented test and fixed the struct-spaces

1d652dc

ordian approved these changes Nov 8, 2018

View reviewed changes

ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Nov 8, 2018

tomusdrw mentioned this pull request Nov 15, 2018

Add experimental RPCs flag #9928

Merged

Merge branch 'master' into in3

094898a

5chdn added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 18, 2018

simon-jentzsch added 2 commits November 19, 2018 15:03

fixed tests

b27be88

added experimental RPCs flag for getProof

151ff09

tomusdrw approved these changes Nov 19, 2018

View reviewed changes

tomusdrw added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Nov 19, 2018

optmized code

ad9c241

5chdn merged commit 8865b95 into openethereum:master Nov 21, 2018

Conversation

simon-jentzsch commented Jun 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parity-cla-bot commented Jun 28, 2018

Uh oh!

5chdn commented Jun 28, 2018

Uh oh!

Uh oh!

Uh oh!

simon-jentzsch commented Jun 28, 2018

Uh oh!

5chdn commented Jun 28, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvdplm commented Jun 29, 2018

Uh oh!

simon-jentzsch commented Jun 29, 2018

Uh oh!

parity-cla-bot commented Jun 29, 2018

Uh oh!

simon-jentzsch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

5chdn commented Jul 2, 2018

Uh oh!

simon-jentzsch commented Jul 8, 2018

Uh oh!

5chdn commented Jul 9, 2018

Uh oh!

sorpaas commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simon-jentzsch commented Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simon-jentzsch commented Sep 21, 2018

Uh oh!

simon-jentzsch commented Oct 17, 2018

Uh oh!

niklasad1 left a comment

Choose a reason for hiding this comment

Uh oh!

Tbaut commented Nov 8, 2018

Uh oh!

simon-jentzsch commented Nov 8, 2018

Uh oh!

ordian left a comment

Choose a reason for hiding this comment

Uh oh!

simon-jentzsch commented Nov 10, 2018

Uh oh!

tomusdrw commented Nov 17, 2018

Uh oh!

simon-jentzsch commented Nov 19, 2018

Uh oh!

tomusdrw left a comment

Choose a reason for hiding this comment

Uh oh!

tomusdrw Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

simon-jentzsch Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

tomusdrw Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

simon-jentzsch commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simon-jentzsch commented Nov 19, 2018

Uh oh!

Reviewers

Assignees

Labels

simon-jentzsch commented Jun 28, 2018 •

edited

Loading

simon-jentzsch left a comment •

edited

Loading

sorpaas commented Jul 19, 2018 •

edited

Loading

simon-jentzsch commented Sep 21, 2018 •

edited

Loading

simon-jentzsch commented Nov 19, 2018 •

edited

Loading