Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Allow transactions, when a configured transactionPermissionContract does not exist #8940

Closed
wulfraem wants to merge 3 commits into from
Closed

Allow transactions, when a configured transactionPermissionContract does not exist #8940

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0de9d2d
default to 'permitted' when validating block transactions with a conf…
wulfraem Jun 21, 2018
c3c1e47
remove excessive logs
wulfraem Jun 21, 2018
df2f9c4
Merge
wulfraem Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ethcore/src/tx_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ impl TransactionFilter {
}

let contract_address = self.contract_address;
if !client.code_hash(&contract_address, BlockId::Hash(*parent_hash)).map_or(false, |c| c != KECCAK_EMPTY) {
trace!(target: "tx_filter", "transaction permission contract does not exist at current block, permitting transaction");
return true;
} else {
trace!(target: "tx_filter", "transaction permission contract exists at current block, checking permissions");

@grbIzl grbIzl Jun 21, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing this trace. It will spam the log

@wulfraem wulfraem Jun 21, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I removed the logs.

}
let contract_version = contract_version_cache.get_mut(parent_hash).and_then(|v| *v).or_else(|| {
self.contract.functions()
.contract_version()
Expand Down