This repository was archived by the owner on Nov 6, 2020. It is now read-only.
hardware_wallet/Ledger Sign messages + some refactoring#8868
Merged
Conversation
* Make `Ledger Manager` only visible inside the hardwallet-crate * Refactor `send_apdu` with separate functions for read and write
niklasad1
added
A0-pleasereview 🤓
folsen
approved these changes
Jun 11, 2018
debris
approved these changes
Jun 13, 2018
Collaborator
debris
left a comment
debris
left a comment
There was a problem hiding this comment.
haven't run it on the device, but code looks good
| use std::str::FromStr; | ||
| use std::sync::{atomic, atomic::AtomicBool, Arc, Weak}; | ||
| use std::time::{Duration, Instant}; | ||
| use std::{fmt, thread}; |
Collaborator
There was a problem hiding this comment.
we usually keep std imports before the others
debris
added
A8-looksgood 🦄
tavakyan
referenced
this pull request
in C4Coin/c4coin-parity
Jun 14, 2018
* getting started * getting started * signing personal messages works and refactoring * Refactor `Ledger` * Make `Ledger Manager` only visible inside the hardwallet-crate * Refactor `send_apdu` with separate functions for read and write * Add support for signing messages through `ethcore` * Trezor modify update_devices and some error msgs * nits
dvdplm
added a commit
that referenced
this pull request
Jun 14, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 20, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: (29 commits) Block 0 is valid in queries (openethereum#8891) fixed osx permissions (openethereum#8901) Atomic create new files with permissions to owner in ethstore (openethereum#8896) Add ETC Cooperative-run load balanced parity node (openethereum#8892) Add support for --chain tobalaba (openethereum#8870) fix some warns on nightly (openethereum#8889) Add new ovh bootnodes and fix port for foundation bootnode 3.2 (openethereum#8886) SecretStore: service pack 1 (openethereum#8435) Handle removed logs in filter changes and add geth compatibility field (openethereum#8796) fixed ipc leak, closes openethereum#8774 (openethereum#8876) scripts: remove md5 checksums (openethereum#8884) hardware_wallet/Ledger `Sign messages` + some refactoring (openethereum#8868) Check whether we need resealing in miner and unwrap has_account in account_provider (openethereum#8853) docker: Fix alpine build (openethereum#8878) Remove mac os installers etc (openethereum#8875) README.md: update the list of dependencies (openethereum#8864) Fix concurrent access to signer queue (openethereum#8854) Tx permission contract improvement (openethereum#8400) Limit the number of transactions in pending set (openethereum#8777) Use sealing.enabled to emit eth_mining information (openethereum#8844) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to close #6083
Also, I refactored the code a bit because it took me a while to understand why some
our existing tests with big payloadfailed for Ledger failed but now all tests forLedgerworks on my laptopOS: Linux archlinux 4.16.13-2
Ledger Firmware version: 1.0.24
Also, I refactored
update_devicesbecause I found it annoying that we turnOk()even if the no devices were detected!