Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Update mod.rs #8695

Merged
Tbaut merged 1 commit into from
May 24, 2018
Merged

Update mod.rs #8695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parity/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ usage! {
["Convenience options"]
FLAG flag_unsafe_expose: (bool) = false, or |c: &Config| c.misc.as_ref()?.unsafe_expose,
"--unsafe-expose",
"All servers will listen on external interfaces and will be remotely accessible. It's equivalent with setting the following: --{{ws,jsonrpc,ui,ipfs,secret_store,stratum}}-interface=all --*-hosts=all This option is UNSAFE and should be used with great care!",
"All servers will listen on external interfaces and will be remotely accessible. It's equivalent with setting the following: --[ws,jsonrpc,ui,ipfs-api,secretstore,stratum,dapps,secretstore-http]-interface=all --*-hosts=all This option is UNSAFE and should be used with great care!",
Copy link
Copy Markdown
Collaborator

@niklasad1 niklasad1 May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't really understand the options 😄

ws = --ws-apis ?
jsonrpc == --jsonrpc-apis?
ui ?
ipfs-api == --ipfs-api?
stratum == --stratum?
dapps == --dapps-apis-all?
secretstore == ?
secretstore-http == --secretstore-http-interface

Can we clarify this consistently (This might be out-of-scope for this PR but ...)?

Copy link
Copy Markdown
Collaborator

@debris debris May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also had problems with understanding this one at first, but it's all right

ws = --ws-interface
jsonrpc == --jsonrpc-interface
ui == --ui-interface
ipfs-api == --ipfs-interface
stratum == --stratum-interface
dapps == --dapps-interface
secretstore == secretstore-interface
secretstore-http == --secretstore-http-interface

Copy link
Copy Markdown
Collaborator

@niklasad1 niklasad1 May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I suggest the change ipfs-api to ipfs for consistency then it's good to go IMO

Copy link
Copy Markdown
Contributor Author

@Tbaut Tbaut May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the names from the available interfaces (https://github.com/paritytech/parity/blob/a002cac95a8a998686215e6b517b5e79986cbaef/parity/cli/mod.rs#L575).
Feel free to change the names and other things to make it clear, this was definitely not what I intended to do for this PR, just making sure things are consistent and up to date.


ARG arg_config: (String) = "$BASE/config.toml", or |_| None,
"-c, --config=[CONFIG]",
Expand Down