This repository was archived by the owner on Nov 6, 2020. It is now read-only.
util fake-fetch#8363
Merged
Merged
Conversation
niklasad1
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
tomusdrw
approved these changes
Apr 11, 2018
| let u = request.url().clone(); | ||
| let (tx, rx) = futures::oneshot(); | ||
| thread::spawn(move || { | ||
| future::ok(if self.val.is_some() { |
Collaborator
There was a problem hiding this comment.
I think thread was introduced here to simulate some asynchronicity (I remember fixing an issue related to this). But I think it's fine as is anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to close #8240
But I haven't fixed yet
dapps/FakeFetchbecause it has more functionality but I want to know whether this is on the right track or not before spending more time on it!Also, the tests in
price_infoneed to be re-factored because they might pass even if the closures are not ever executed, https://github.com/paritytech/parity/blob/master/price-info/src/lib.rs#L216-#L255/cc @debris