Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fix snapcraft nightly#7884

Merged
5chdn merged 11 commits into
masterfrom
a5-ci-snap
Feb 14, 2018
Merged

Fix snapcraft nightly#7884
5chdn merged 11 commits into
masterfrom
a5-ci-snap

Conversation

@5chdn
Copy link
Copy Markdown
Contributor

@5chdn 5chdn commented Feb 13, 2018

No description provided.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. B0-patch M1-ci 🙉 Continuous integration. labels Feb 13, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 13, 2018
@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Feb 14, 2018

This is blocked by paritytech/parity-import-tests#3

@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Feb 14, 2018

Nightly is all green now: https://gitlab.parity.io/parity/parity/pipelines/17901

🎉

Comment thread .gitlab-ci.yml
artifacts:
paths:
- scripts/parity_*_amd64.snap
- parity.zip
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something that indicates that it's a snap? (to don't confuse it with packed binary or sth)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only in artifacts on gitlab. for tests, we are not push in release

@tomusdrw tomusdrw added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 14, 2018
@5chdn 5chdn merged commit 1cce3cf into master Feb 14, 2018
@5chdn 5chdn deleted the a5-ci-snap branch February 14, 2018 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M1-ci 🙉 Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants