Conversation
NikVolf
added
A0-pleasereview 🤓
|
if it's metered the same way as the regular (?) memory is it really a DoS vector? |
|
@rphmeier sure, could be, but webassembly spec does not allow to judge about module internal memory (as long as it is not exported) during execution while we of course can hack around and meter internal memoery it by the module composition before instantiation, I would prefer to avoid it at all so other implementations that use different engines and api-s (which might not allow this hack) could match rules So I can still add metering, but it's really hard to imagine contract that does not use shared memory with runtime, it can do almost nothing. |
NikVolf
added
A3-inprogress ⏳
|
@rphmeier |
NikVolf
added
A0-pleasereview 🤓
* update back-references more aggressively after answering from cache (#7578) * Add new EF ropstens nodes. (#7824) * Add new EF ropstens nodes. * Fix tests * Add a timeout for light client sync requests (#7848) * Add a timeout for light client sync requests * Adjusting timeout to number of headers * Flush keyfiles. Resolves #7632 (#7868) * Fix wallet import (#7873) * rpc: generate new account id for imported wallets * ethstore: handle duplicate wallet filenames * ethstore: simplify deduplication of wallet file names * ethstore: do not dedup wallet filenames on update * ethstore: fix minor grumbles * [WASM] mem_cmp added to the Wasm runtime (#7539) * mem_cmp added to the Wasm runtime * schedule.wasm.mem_copy to schedule.wasm.mem_cmp for mem_cmp * [Wasm] memcmp fix and test added (#7590) * [Wasm] memcmp fix and test added * [Wasm] use reqrep_test! macro for memcmp test * wasmi interpreter (#7796) * adjust storage update evm-style (#7812) * disable internal memory (#7842)
4 participants
It's useless for meaningful contracts, while having it opens network for dos attack