This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Enable Panic=abort#3423
Merged
Merged
Conversation
arkpar
added
A0-pleasereview 🤓
arkpar
force-pushed
the
panic-abort
branch
3 times, most recently
from
0093d8b to
fc3aa82
Compare
|
Changes Unknown when pulling ca4fc3e on panic-abort into * on master*. |
|
Changes Unknown when pulling 3cd00da on panic-abort into * on master*. |
|
Changes Unknown when pulling 31d0d4f on panic-abort into ** on master**. |
|
Changes Unknown when pulling d652784 on panic-abort into ** on master**. |
arkpar
added
A0-pleasereview 🤓
Contributor
|
perf gains/binary size difference? |
Collaborator
Author
|
Binary is 2 megabytes smaller. Compilation 5% faster. |
Contributor
|
Sounds good. Hope it all works :) Out of curiousity, will this make it harder for users to report panics when they do happen, now that there's no unwind? Are there any backtraces/panic message? |
Collaborator
Author
|
No, stack backtrace and panic message is still there. |
rphmeier
added
A8-looksgood 🦄
Contributor
|
relnotes for this one? |
Collaborator
Author
|
Don't think it affects users in any way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.