This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Transaction Queue fix#2392
Merged
Merged
Conversation
Merged
arkpar
added
A8-looksgood 🦄
jacogr
added a commit
that referenced
this pull request
Oct 1, 2016
* js: signaturereg registered, remove hardcoding fixes for non-null returns update ABIs to latest deployed versions update Morden registry address (#2417) using arc (#2420) asterisk space removed redundant memcopy Update gitlab-ci Fixing logs-receipt matching (#2403) fix broken beta compilation Fixing transaction queue (#2392) separate mod for tests bloom filter crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving transactions between Future and Current it could happen that transaction with the same
(Sender, Nonce)was already in the other queue.My understanding is that such situation could happen when some transactions were not cleared from the queue:
nonce1 > expected_nonce)nonce == expected_nonce == nonce1 + 1)This would leave an old transaction in Future (
fn update_futurewould not remove it). Then in case of chain re-org same transactionnonce1could be imported again to current causing a clash.