Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Disable warp sync snapshotting by default#11814

Merged
vorot93 merged 1 commit into
masterfrom
vorot93/no-periodic-snapshot
Jul 15, 2020
Merged

Disable warp sync snapshotting by default#11814
vorot93 merged 1 commit into
masterfrom
vorot93/no-periodic-snapshot

Conversation

@vorot93
Copy link
Copy Markdown

@vorot93 vorot93 commented Jul 9, 2020

screenshot

Warp sync snapshotting takes quite a lot of RAM. This may make OpenEthereum unusable on many otherwise fine configurations. More than that, snapshotting by laymen may be unnecessary because:

  • For public networks we maintain perfectly capable warp-sync-ready bootnodes.
  • For private networks it makes more sense to simply backup the database and restore the chain database to the nodes verbatim.

Copy link
Copy Markdown

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some compilation errors there, @vorot93

@vorot93 vorot93 force-pushed the vorot93/no-periodic-snapshot branch from c10f964 to efbfe99 Compare July 11, 2020 03:44
@vorot93
Copy link
Copy Markdown
Author

vorot93 commented Jul 11, 2020

Oddly enough, you cannot specify flags to default to true. I've made a new --enable-snapshotting flag instead. This is a breaking change for those who used the old --no-periodic-snapshots flag.

@vorot93 vorot93 force-pushed the vorot93/no-periodic-snapshot branch from efbfe99 to d0f6c1b Compare July 12, 2020 06:12
Copy link
Copy Markdown

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vorot93 vorot93 merged commit 4cdaa19 into master Jul 15, 2020
@vorot93 vorot93 deleted the vorot93/no-periodic-snapshot branch July 15, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants