Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

[ethcore cleanup]: various unrelated fixes from #11493#11507

Merged
dvdplm merged 4 commits into
masterfrom
na-cleanups
Feb 25, 2020
Merged

[ethcore cleanup]: various unrelated fixes from #11493#11507
dvdplm merged 4 commits into
masterfrom
na-cleanups

Conversation

@niklasad1
Copy link
Copy Markdown
Collaborator

@niklasad1 niklasad1 commented Feb 21, 2020

Fixes grumbles in #11493 (comment)

Comment thread ethcore/src/client/client.rs Outdated
Comment thread ethcore/engines/clique/src/lib.rs Outdated
@ordian ordian added the A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. label Feb 25, 2020
@dvdplm dvdplm merged commit cd70180 into master Feb 25, 2020
@dvdplm dvdplm deleted the na-cleanups branch February 25, 2020 14:32
ordian added a commit that referenced this pull request Mar 6, 2020
* master: (27 commits)
  Faster kill_garbage (#11514)
  [EngineSigner]: don't sign message with only zeroes (#11524)
  fix compilation warnings (#11522)
  [ethcore cleanup]: various unrelated fixes from `#11493` (#11507)
  Add benchmark for transaction execution (#11509)
  Add Smart Contract License v1.0
  Misc fixes (#11510)
  [dependencies]: unify `rustc-hex` (#11506)
  Activate on-chain randomness in POA Sokol (#11505)
  Grab bag of cleanup (#11504)
  Implement eth/64 (EIP-2364) and drop support for eth/62 (#11472)
  [dependencies]: remove `util/macros` (#11501)
  OpenEthereum bootnodes are added (#11499)
  [ci benches]: use `all-features` (#11496)
  [verification]: make test-build compile standalone (#11495)
  complete null-signatures removal (#11491)
  Include the seal when populating the header for a new block (#11475)
  fix compilation warnings (#11492)
  cargo update -p cmake (#11490)
  update to published rlp-derive (#11489)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants