Add EIP-1884 SLOAD_GAS change to EIP-2200

[GregTheGreek]

I was doing some bench marking and analysis surrounding some of the recent EIPs. While tinkering with EIP-1884 I accidentally created a split on a private network between Parity, Besu and Geth, where Parity and Geth forked together with SLOAD_GAS of 200 rather than 800. After investigating, I discovered that EIP-2200 was "technically" incorrectly implemented.

EIP-1884 and EIP-2200 both adjust SLOAD_GAS from 200 to 800 - but the current implementation of EIP-2200 assumes that EIP-1884 is already implemented, and only adjusts SSTORE.

This PR adds the EIP-1884 SLOAD_GAS changes to EIP-2200.

There is a Sibling PR in Geth

[parity-cla-bot]

It looks like @GregTheGreek signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[ordian]

EIP-1884 and EIP-2200 both adjust SLOAD_GAS from 200 to 800 - but the current implementation of EIP-2200 assumes that EIP-1884 is already implemented, and only adjusts SSTORE.

My understanding that eip2200_advanced_transition is not the same as eip2200_transition, which is eip1283_transition + eip1706_transition + eip1884_transition: #11347

cc @sorpaas

[sorpaas]

The SLOAD_GAS in EIP-2200 actually has nothing to do with SLOAD -- it's simply the dirty gas for SSTORE. Geth has the naming of it more precisely. So "technically" the current implementations in Parity and Geth are correct.

But anyway having it or not should not make much difference, given we always activate EIP-2200 with EIP-1884.