This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Avoid copies#11451
Merged
Merged
Conversation
dvdplm
added
A0-pleasereview 🤓
ordian
approved these changes
Feb 4, 2020
niklasad1
approved these changes
Feb 4, 2020
Collaborator
You are right, https://doc.rust-lang.org/src/alloc/slice.rs.html#138-161 |
ordian
added a commit
that referenced
this pull request
Feb 5, 2020
dvdplm
added a commit
that referenced
this pull request
Feb 8, 2020
…pstream * master: upgrade some of the dependencies (#11467) Some more release track changes to README.md (#11465) Update simple one-line installer due to switching to a single stable release track (#11463) update Dockerfile (#11461) Implement EIP-2124 (#11456) [eth classic chainspec]: remove `balance = 1` (#11459) just to make sure we don't screw up this again (#11455) backwards compatible call_type creation_method (#11450) gcc to clang (#11453) Avoid copies (#11451) Cargo.lock: cargo lock translate (#11448)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer
into_vec()overto_vec()of owned data to avoid unecessary copies. Maybe the compiler already sees this and optimizes it away, but yeah, better be explicit.