This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Conversation
dvdplm
added
A3-inprogress ⏳
Collaborator
|
@tomusdrw let's merge this as-is and if you find the SVG you can open a new PR yes? :) |
Collaborator
Author
|
Ah thanks for the reminder! It's on my old laptop, will look for it tonight. Merging sounds good, will update in another PR. |
dvdplm
added
A0-pleasereview 🤓
dvdplm
approved these changes
Jan 29, 2020
Collaborator
Author
|
I'm really sorry but I wasn't able to find the original SVG version of the diagram on my old machine neither. I guess if needed it could be recreated (I used draw.io for that afair). |
ordian
approved these changes
Feb 3, 2020
dvdplm
added a commit
that referenced
this pull request
Feb 4, 2020
dvdplm
added a commit
that referenced
this pull request
Feb 4, 2020
…pstream * master: Avoid long state queries when serving GetNodeData requests (#11444) Cargo.lock: cargo update -p kvdb-rocksdb (#11447) rlp_derive: cleanup (#11446) chore: remove unused dependencies (#11432) update kvdb-rocksdb to 0.4 (#11442) Rough architecutre diagram. (#11396) ethjson: impl Copy for hash type wrapper (#11423) Remove dead bootnodes, add new geth bootnodes (#11441) goerli: replace foundation bootnode (#11433) Update publish-docker.sh (#11428) Revert "[Trace] Distinguish between `create` and `create2` (#11311)" (#11427)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a PNG rendition of rough, unfinished architecture diagram. Marking the PR as a draft, as I need to look for a SVG version somewhere on my old laptop.
My idea was to make it interactive and be able to see how messages flow through the modules, but never had enough time to finish it.
Still, I believe it's beneficial to roughly describe how the code is split.