This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
removed redundant VMType enum with one variant #11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
|
It would be nice to be able to plug custom evm impls (like https://github.com/ethereum/evmone) via https://github.com/ethereum/evmc, wdyt? |
dvdplm
approved these changes
Nov 15, 2019
I'm not sure. I'll look it
Of course, but this is just a nice to have feature. If anyone really wants it and commits to the compatibility maintenance of it, we can add it. |
dvdplm
added a commit
that referenced
this pull request
Nov 20, 2019
* master: Clarify what first_block `None` means (#11269) removed redundant VMType enum with one variant (#11266) Ensure jsonrpc threading settings are sane (#11267) Return Ok(None) when the registrar contract returns empty slice (#11257) Add a benchmark for snapshot::account::to_fat_rlps() (#11185) Fix misc compile warnings (#11258) simplify verification (#11249)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past (3-4 years ago), parity supported 2 implementations of evm. rust interpreter and cpp-jit. Since jit is not supported for a very long time,
VMTypeenum with one variant is completely redundant