Add Nat PMP method to P2P module by NamsooCho · Pull Request #11210 · openethereum/parity-ethereum

NamsooCho · 2019-10-28T08:36:35Z

Add Nat PMP method to P2P module.
I am not sure if it is needed and correct.
I will add tests fn to this PR after someone comments that this PR is correct.

parity-cla-bot · 2019-10-28T08:36:38Z

It looks like @NamsooCho signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

dvdplm · 2019-10-28T14:04:42Z

My biggest concern here is: why do we need NAT-PMP? What problem does it solve, what is the gain? I know of no NAT related issues our users are having but maybe I'm wrong.

Another curiosity: it seems like NAT-PMP is superseded by NAT-PCP so if there is a NAT problem, why not go for the current standard? Is it because no NAT-PCP libraries exist in Rust? Or...?

NamsooCho · 2019-10-29T00:45:32Z

NAT-PCP is not widely used in real-world.
https://superuser.com/questions/1301857/using-pcp-port-control-protocol-in-practice

There are some security issues in UPnP.
https://www.howtogeek.com/122487/htg-explains-is-upnp-a-security-risk/

NAP-PMP is widely used and has not been reported to have security issues.

If we support NAT PMP then users can disable UPnP.

dvdplm · 2019-10-29T09:42:00Z

NAP-PMP is widely used and has not been reported to have security issues.

I have read about the security concerns regarding upnp (thank you for the link!) but unless I'm missing something the same concerns apply to NAT-PMP in that it also assumes the local application requesting a port mapping is trustworthy? Or are there other security concerns with upnp?

seunlanlege

Needs some code style corrections, and other question answered.

NamsooCho · 2019-10-30T01:01:49Z

the same concerns apply to NAT-PMP in that it also assumes the local application requesting a port mapping is trustworthy?

Yes. Sorry for careless response.

I found this article.
https://discussions.apple.com/docs/DOC-9292

According to the article, Apple routers do not support UPnP.

dvdplm

I think we're close, good job!

ngotchac · 2019-11-27T09:52:50Z

+			match Natpmp::new() {
+				Ok(mut n) => {
+					let gw = get_public_addr(&mut n)?;
+					let tcp_r = get_mapped_tcp_port(&mut n)?;
+					let udp_r = get_mapped_udp_port(&mut n)?;
+
+					Ok(NodeEndpoint {
+						address: SocketAddr::V4(SocketAddrV4::new(*gw.public_address(), tcp_r.public_port())),
+						udp_port: udp_r.public_port()
+					})
+				},
+				Err(e) => Err(e)
+			}


I'd suggest using let mut n = Natpmp::new()?; here, and remove the function closures (get_mapped_udp_port and such)

ngotchac

A few grumbles

ngotchac · 2019-11-27T09:53:27Z

+		return search_gateway_child.join()
+			.map(|node| {
+				node.map_err(|e| debug!("NAT PMP port mapping error: {:?}", e)).ok()
+			}).ok()?


You could do:

return search_gateway_child.join().ok()? .map_err(|e| debug!("NAT PMP port mapping error: {:?}", e)) .ok();

ngotchac · 2019-11-27T09:53:51Z

+				match n.read_response_or_retry() {
+					Ok(Response::TCP(tcp)) => Ok(tcp),
+					Err(e) => {
+						debug!("Port mapping for TCP error: {}", e);


Please add a target to the debug and such logs

dvdplm · 2019-12-05T08:39:28Z

@ngotchac @seunlanlege please take a look again.

dvdplm · 2019-12-10T05:43:19Z

ping @ngotchac @seunlanlege

ngotchac · 2019-12-10T08:14:31Z

None of my comments have been addressed or answered yet

seunlanlege

Just going to approve this, once @ngotchac's comments have been addressed, it can be merged

ngotchac · 2019-12-11T18:04:27Z

+
+			let mut n = Natpmp::new()?;
+
+			let gw = get_public_addr(&mut n)?;


You could replace the function closure with a direct call as you did bellow IMO

ngotchac

👍

* master: Add Nat PMP method to P2P module (#11210) Add randomness contract support to AuthorityRound. (#10946) ethcore/res: activate ecip-1061 on kotti and mordor (#11338)

jam10o-new added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 28, 2019

NamsooCho force-pushed the natpmp branch from 794346a to d202dfc Compare October 29, 2019 01:16

NamsooCho changed the title ~~[WIP] Add Nat PMP method to P2P module~~ Add Nat PMP method to P2P module Oct 29, 2019

seunlanlege suggested changes Oct 29, 2019

View reviewed changes

Comment thread util/network-devp2p/src/ip_utils.rs Outdated

Comment thread util/network-devp2p/src/ip_utils.rs Outdated

Comment thread util/network-devp2p/src/ip_utils.rs Outdated

Comment thread util/network-devp2p/src/ip_utils.rs Outdated

NamsooCho force-pushed the natpmp branch from e1254b3 to 0b7aaac Compare October 31, 2019 01:48

NamsooCho requested a review from seunlanlege October 31, 2019 23:28

NamsooCho force-pushed the natpmp branch 2 times, most recently from bad5168 to 98442cd Compare November 6, 2019 00:45

dvdplm reviewed Nov 6, 2019

View reviewed changes

NamsooCho force-pushed the natpmp branch from 98442cd to 68494f2 Compare November 13, 2019 02:03

dvdplm reviewed Nov 13, 2019

View reviewed changes

Comment thread util/network-devp2p/src/ip_utils.rs Outdated

dvdplm requested a review from ngotchac November 13, 2019 10:19

NamsooCho force-pushed the natpmp branch 2 times, most recently from 3f5121d to d420dfd Compare November 22, 2019 03:31

ngotchac reviewed Nov 27, 2019

View reviewed changes

NamsooCho force-pushed the natpmp branch from d420dfd to c3207ca Compare November 29, 2019 00:18

dvdplm requested a review from ngotchac December 5, 2019 08:39

seunlanlege approved these changes Dec 10, 2019

View reviewed changes

NamsooCho force-pushed the natpmp branch 2 times, most recently from d00ca89 to 1796ae4 Compare December 11, 2019 00:36

ngotchac reviewed Dec 11, 2019

View reviewed changes

NamsooCho force-pushed the natpmp branch from 1796ae4 to 80a7c6a Compare December 12, 2019 00:14

ngotchac approved these changes Dec 17, 2019

View reviewed changes

NamsooCho added 6 commits December 17, 2019 18:44

Add Nat PMP method to P2P module

bcaeebb

Add test fn

096a156

Use closure

24d79a9

print richer error messages.

df721ab

reformat long code line

f3e29f9

remove closures

5e377ca

NamsooCho force-pushed the natpmp branch from 80a7c6a to 5e377ca Compare December 17, 2019 09:45

dvdplm merged commit e14d68e into openethereum:master Dec 19, 2019


		let mut n = Natpmp::new()?;

		let gw = get_public_addr(&mut n)?;

Conversation

NamsooCho commented Oct 28, 2019

Uh oh!

parity-cla-bot commented Oct 28, 2019

Uh oh!

dvdplm commented Oct 28, 2019

Uh oh!

NamsooCho commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dvdplm commented Oct 29, 2019

Uh oh!

seunlanlege left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NamsooCho commented Oct 30, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvdplm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngotchac left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvdplm commented Dec 5, 2019

Uh oh!

dvdplm commented Dec 10, 2019

Uh oh!

ngotchac commented Dec 10, 2019

Uh oh!

seunlanlege left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngotchac left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NamsooCho commented Oct 29, 2019 •

edited

Loading