Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

[ethcore]: move client test types to test-helpers#11062

Merged
ascjones merged 1 commit into
masterfrom
na-ethcore-more-move-test-types
Sep 17, 2019
Merged

[ethcore]: move client test types to test-helpers#11062
ascjones merged 1 commit into
masterfrom
na-ethcore-more-move-test-types

Conversation

@niklasad1
Copy link
Copy Markdown
Collaborator

@niklasad1 niklasad1 commented Sep 17, 2019

This PR moves the test types EvmTestClient and TestBlockChainClient from ethcore/src/client to ethcore/test_helpers because those are not needed by non-test builds

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 17, 2019
@ordian ordian added this to the 2.7 milestone Sep 17, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 17, 2019
@ascjones ascjones merged commit b6415c6 into master Sep 17, 2019
@ascjones ascjones deleted the na-ethcore-more-move-test-types branch September 17, 2019 14:42
dvdplm added a commit that referenced this pull request Sep 18, 2019
@dvdplm
Merge branch 'master' into dp/chore/new-ethereum-consensus-tests
1ab7ec6 
* master:
  [ethcore]: move client test types to test-helpers (#11062)
  [sync]: remove unused dependencies or make dev (#11061)
  [ethcore]: reduce re-exports (#11059)
  [evmbin] fix time formatting (#11060)
  Update hardcoded headers (foundation, classic, kovan,  xdai, ewc, ...) (#11053)
  cargo update -p eth-secp256k1 (#11052)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ascjones ascjones ascjones approved these changes

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@niklasad1 @ascjones @ordian