Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

ethcore: remove test-helper feat from build (#11047)#11049

Merged
dvdplm merged 1 commit into
betafrom
dp/chore/backport-11047-dont-build-with-test-helpers-beta
Sep 13, 2019
Merged

ethcore: remove test-helper feat from build (#11047)#11049
dvdplm merged 1 commit into
betafrom
dp/chore/backport-11047-dont-build-with-test-helpers-beta

Conversation

@dvdplm
Copy link
Copy Markdown
Collaborator

@dvdplm dvdplm commented Sep 13, 2019

Backport #11047 to beta.

@dvdplm dvdplm requested review from niklasad1 and s3krit September 13, 2019 09:42
@dvdplm dvdplm self-assigned this Sep 13, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Sep 13, 2019
Copy link
Copy Markdown
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdplm dvdplm merged commit 06287c4 into beta Sep 13, 2019
@dvdplm dvdplm deleted the dp/chore/backport-11047-dont-build-with-test-helpers-beta branch September 13, 2019 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants