Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

xDai chain support and nodes list update#10989

Merged
dvdplm merged 4 commits into
openethereum:masterfrom
phahulin:poanets-update
Aug 29, 2019
Merged

xDai chain support and nodes list update#10989
dvdplm merged 4 commits into
openethereum:masterfrom
phahulin:poanets-update

Conversation

@phahulin
Copy link
Copy Markdown
Contributor

@phahulin phahulin commented Aug 26, 2019 •
edited
Loading

  1. update list of bootnodes for POA Core, POA Sokol and Kovan
  2. add xDai Chain with --chain xdai

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Aug 26, 2019

It looks like @phahulin signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jam10o-new jam10o-new added A0-pleasereview 🤓 Pull request needs code review. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B1-patch-beta 🕷🕷 M2-config 📂 Chain specifications and node configurations. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. labels Aug 27, 2019
@dvdplm
Copy link
Copy Markdown
Collaborator

dvdplm commented Aug 27, 2019

@phahulin Do you have any advice on how to review these changes other than blind trust?

@phahulin
Copy link
Copy Markdown
Contributor Author

phahulin commented Aug 28, 2019

@dvdplm Glad you asked.
I put links to the original POA Network repos in the description (e.g., this is the link to xDai spec json file).

But I suppose a better way would be to compile the binary, sync the chain with --chain xdai --no-warp and compare block hashes with other available resources like netstats or blockscout. Also nodesmith supports xDai nodes.
It shouldn't take too long to sync.

dvdplm
dvdplm approved these changes Aug 28, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced xDAI.

@ordian ordian added this to the 2.7 milestone Aug 28, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 28, 2019
@dvdplm dvdplm merged commit 3420c2b into openethereum:master Aug 29, 2019
dvdplm added a commit that referenced this pull request Aug 29, 2019
@dvdplm
Merge branch 'master' into dp/feature/eip-1884-reprice-trie-size-depe…
0e4762c 
…ndent-ops

* master:
  xDai chain support and nodes list update (#10989)
  [trace] check mem diff within range (#11002)
  EIP-1344 Add CHAINID op-code (#10983)
ordian added a commit to ordian/parity that referenced this pull request Aug 29, 2019
@ordian
Merge branch 'master' into ao-move-memdiff-to-trace-executed
5b4a438 
* master:
  EIP 1884 Re-pricing of trie-size dependent operations (openethereum#10992)
  xDai chain support and nodes list update (openethereum#10989)
  [trace] check mem diff within range (openethereum#11002)
  EIP-1344 Add CHAINID op-code (openethereum#10983)
  Make ClientIoMessage generic over the Client (openethereum#10981)
  bump spin to 0.5.2 (openethereum#10996)
  fix compile warnings (openethereum#10993)
s3krit pushed a commit that referenced this pull request Sep 11, 2019
@phahulin @s3krit
xDai chain support and nodes list update (#10989)
dc3b30f 
* Update bootnodes list for known networks

* Add XDai chain

* Rename xdai chain in config

* Fix missing comma
s3krit pushed a commit that referenced this pull request Sep 11, 2019
@phahulin @s3krit
xDai chain support and nodes list update (#10989)
1821ebc 
* Update bootnodes list for known networks

* Add XDai chain

* Rename xdai chain in config

* Fix missing comma
This was referenced Sep 12, 2019
Merged
Merged
s3krit added a commit that referenced this pull request Sep 12, 2019
@s3krit
v2.6.3-beta (#11040)
6ad6c3c 
* add more tx tests (#11038)
* Fix parallel transactions race-condition (#10995)
* Add blake2_f precompile (#11017)
* [trace] introduce trace failed to Ext (#11019)
* Edit publish-onchain.sh to use https (#11016)
* Fix deadlock in network-devp2p (#11013)
* EIP 1108: Reduce alt_bn128 precompile gas costs (#11008)
* xDai chain support and nodes list update (#10989)
* EIP 2028: transaction gas lowered from 68 to 16 (#10987)
* EIP-1344 Add CHAINID op-code (#10983)
* manual publish jobs for releases, no changes for nightlies (#10977)
* [blooms-db] Fix benchmarks (#10974)
* Verify transaction against its block during import (#10954)
* Better error message for rpc gas price errors (#10931)
* Fix fork choice (#10837)
* Fix compilation on recent nightlies (#10991)
s3krit added a commit that referenced this pull request Sep 12, 2019
@s3krit
v2.5.8-stable (#11041)
45f27ce 
* add more tx tests (#11038)
* Fix parallel transactions race-condition (#10995)
* Add blake2_f precompile (#11017)
* [trace] introduce trace failed to Ext (#11019)
* Edit publish-onchain.sh to use https (#11016)
* Fix deadlock in network-devp2p (#11013)
* EIP 1108: Reduce alt_bn128 precompile gas costs (#11008)
* xDai chain support and nodes list update (#10989)
* EIP 2028: transaction gas lowered from 68 to 16 (#10987)
* EIP-1344 Add CHAINID op-code (#10983)
* manual publish jobs for releases, no changes for nightlies (#10977)
* [blooms-db] Fix benchmarks (#10974)
* Verify transaction against its block during import (#10954)
* Better error message for rpc gas price errors (#10931)
* tx-pool: accept local tx with higher gas price when pool full (#10901)
* Fix fork choice (#10837)
* Cleanup unused vm dependencies (#10787)
* Fix compilation on recent nightlies (#10991)
@adria0 adria0 mentioned this pull request Nov 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@jam10o-new jam10o-new jam10o-new approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M2-config 📂 Chain specifications and node configurations.

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@phahulin @parity-cla-bot @dvdplm @jam10o-new @ordian