This repository was archived by the owner on Nov 6, 2020. It is now read-only.
bump crossbeam#10848
Merged
Merged
Conversation
Collaborator
debris
commented
Jul 5, 2019
debris
commented
- reduces the number of duplicated dependencies
debris
added
A0-pleasereview 🤓
debris
commented
Jul 5, 2019
| .join() | ||
| }) | ||
| .expect("Sub-thread never panics; qed") | ||
| .expect("Sub-thread never panics; qed") |
Collaborator
Author
There was a problem hiding this comment.
crossbeamapi has changed a bit here,
- We have to call
joininsidefn scopecallback, cause thejoinhandle lifetime is now the same as scope lifetime :( fn scopereturns error, so that's why we have doubleexpecthere
Collaborator
There was a problem hiding this comment.
fn scope returns error,
What are the conditions under which it errors?
Collaborator
Author
There was a problem hiding this comment.
If the child thread panics, an error is returned.
from https://docs.rs/crossbeam/0.7.1/crossbeam/thread/struct.ScopedJoinHandle.html
and
If any of the joined threads has panicked, an Err is returned containing errors from panicked threads.
from https://docs.rs/crossbeam/0.7.1/crossbeam/fn.scope.html
ordian
added
A8-looksgood 🦄
ordian
approved these changes
Jul 5, 2019
dvdplm
approved these changes
Jul 5, 2019
| .join() | ||
| }) | ||
| .expect("Sub-thread never panics; qed") | ||
| .expect("Sub-thread never panics; qed") |
Collaborator
There was a problem hiding this comment.
fn scope returns error,
What are the conditions under which it errors?
ordian
pushed a commit
that referenced
this pull request
Aug 12, 2019
ordian
pushed a commit
that referenced
this pull request
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.