This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Break circular dependency between Client and Engine (part 1)#10833
Merged
Conversation
dvdplm
commented
Jul 2, 2019
| engine.populate_from_parent(&mut r.block.header, parent); | ||
|
|
||
| engine.machine().on_new_block(&mut r.block)?; | ||
| engine.on_new_block(&mut r.block, is_epoch_begin, &mut ancestry.into_iter())?; |
Collaborator
Author
There was a problem hiding this comment.
The ancestry was never used so I'm not sure what it was used for tbh.
Collaborator
There was a problem hiding this comment.
This was for engines that need to compute additional information regarding finalisation (for example, finalise blocks based on ancestor finalisation information).
Looks like we at least don’t need it right now!
debris
approved these changes
Jul 3, 2019
| engine.populate_from_parent(&mut r.block.header, parent); | ||
|
|
||
| engine.machine().on_new_block(&mut r.block)?; | ||
| engine.on_new_block(&mut r.block, is_epoch_begin, &mut ancestry.into_iter())?; |
debris
added
A8-looksgood 🦄
sorpaas
approved these changes
Jul 4, 2019
| engine.populate_from_parent(&mut r.block.header, parent); | ||
|
|
||
| engine.machine().on_new_block(&mut r.block)?; | ||
| engine.on_new_block(&mut r.block, is_epoch_begin, &mut ancestry.into_iter())?; |
Collaborator
There was a problem hiding this comment.
This was for engines that need to compute additional information regarding finalisation (for example, finalise blocks based on ancestor finalisation information).
Looks like we at least don’t need it right now!
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
…me-parent * master: refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657) idiomatic changes to PodState (#10834) Allow --nat extip:your.host.here.org (#10830) When updating the client or when called from RPC, sleep should mean sleep (#10814) Remove excessive warning (#10831) Fix typo in README.md (#10828) ethcore does not use byteorder (#10829) Better logging when backfilling ancient blocks fail (#10796) depends: Update wordlist to v1.3 (#10823)
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
* master: refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657) idiomatic changes to PodState (#10834) Allow --nat extip:your.host.here.org (#10830) When updating the client or when called from RPC, sleep should mean sleep (#10814) Remove excessive warning (#10831) Fix typo in README.md (#10828) ethcore does not use byteorder (#10829) Better logging when backfilling ancient blocks fail (#10796) depends: Update wordlist to v1.3 (#10823) cargo update -p smallvec (#10822) replace memzero with zeroize crate (#10816) Don't repeat the logic from Default impl (#10813) removed additional_params method (#10818) Add Constantinople eips to the dev (instant_seal) config (#10809)
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
* master: (21 commits) refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657) idiomatic changes to PodState (#10834) Allow --nat extip:your.host.here.org (#10830) When updating the client or when called from RPC, sleep should mean sleep (#10814) Remove excessive warning (#10831) Fix typo in README.md (#10828) ethcore does not use byteorder (#10829) Better logging when backfilling ancient blocks fail (#10796) depends: Update wordlist to v1.3 (#10823) cargo update -p smallvec (#10822) replace memzero with zeroize crate (#10816) Don't repeat the logic from Default impl (#10813) removed additional_params method (#10818) Add Constantinople eips to the dev (instant_seal) config (#10809) removed redundant fmt::Display implementations (#10806) revert changes to .gitlab-ci.yml (#10807) Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506) ...
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
* master: Extricate PodAccount and state Account to own crates (#10838) logs (#10817) refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
…hore/extricate-state-backend * dp/chore/extricate-account-db-into-own-crate: third time's the charm test failure 2 test failure Extricate PodAccount and state Account to own crates (#10838) logs (#10817) refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
This was referenced Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. #9114
Don't use the
Clientto look up the parent block so we can calculate the parent step. Instead, store the parent header in theOpenBlockand pass it toon_close_block().It is unsatisfying to store a whole
Headerin allOpenBlocks/ClosedBlocksjust because Aura need the parent step (au64), but all calls toOpenBlock::new()already pass in the parentHeader(so no new lookup/decoding). I tried to store a reference instead butreopen()is problematic.