Die error_chain, die by ascjones · Pull Request #10747 · openethereum/parity-ethereum

ascjones · 2019-06-14T09:58:30Z

Resolves #10302.

dvdplm

lovely, lgtm.

ordian

Noice!

dvdplm

missing space

dvdplm · 2019-06-17T06:07:05Z

+	/// Rlp decoder error.
+	Rlp(rlp::DecoderError),
+	/// Error concerning the network address parsing subsystem.
+	#[display(fmt ="Failed to parse network address")]


Suggested change

#[display(fmt ="Failed to parse network address")]

#[display(fmt = "Failed to parse network address")]

dvdplm · 2019-06-17T06:07:29Z

+	#[display(fmt ="Failed to parse network address")]
+	AddressParse,
+	/// Error concerning the network address resolution subsystem.
+	#[display(fmt ="Failed to resolve network address {}", _0)]


Suggested change

#[display(fmt ="Failed to resolve network address {}", _0)]

#[display(fmt = "Failed to resolve network address {}", _0)]

dvdplm · 2019-06-17T06:07:37Z

+	#[display(fmt ="Failed to resolve network address {}", _0)]
+	AddressResolve(AddressResolveError),
+	/// Authentication failure
+	#[display(fmt ="Authentication failure")]


Suggested change

#[display(fmt ="Authentication failure")]

#[display(fmt = "Authentication failure")]

dvdplm · 2019-06-17T06:07:46Z

+	#[display(fmt ="Authentication failure")]
+	Auth,
+	/// Unrecognised protocol
+	#[display(fmt ="Bad protocol")]


Suggested change

#[display(fmt ="Bad protocol")]

#[display(fmt = "Bad protocol")]

dvdplm · 2019-06-17T06:07:54Z

+	#[display(fmt ="Bad protocol")]
+	BadProtocol,
+	/// Expired message
+	#[display(fmt ="Expired message")]


Suggested change

#[display(fmt ="Expired message")]

#[display(fmt = "Expired message")]

dvdplm · 2019-06-17T06:08:19Z

+	#[display(fmt ="Peer disconnected: {}", _0)]
+	Disconnect(DisconnectReason),
+	/// Invalid node id
+	#[display(fmt ="Invalid node id")]


Suggested change

#[display(fmt ="Invalid node id")]

#[display(fmt = "Invalid node id")]

dvdplm · 2019-06-17T06:08:27Z

+	#[display(fmt ="Invalid node id")]
+	InvalidNodeId,
+	/// Packet size is over the protocol limit
+	#[display(fmt ="Packet is too large")]


Suggested change

#[display(fmt ="Packet is too large")]

#[display(fmt = "Packet is too large")]

dvdplm · 2019-06-17T06:08:36Z

+	#[display(fmt ="Packet is too large")]
+	OversizedPacket,
+	/// Reached system resource limits for this process
+	#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")]


Suggested change

#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")]

#[display(fmt = "Too many open files in this process. Check your resource limits and restart parity")]

dvdplm · 2019-06-17T06:08:44Z

+	#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")]
+	ProcessTooManyFiles,
+	/// Reached system wide resource limits
+	#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]


Suggested change

#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]

#[display(fmt = "Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]

dvdplm · 2019-06-17T06:08:51Z

+	#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]
+	SystemTooManyFiles,
+	/// An unknown IO error occurred.
+	#[display(fmt ="Unexpected IO error: {}", _0)]


Suggested change

#[display(fmt ="Unexpected IO error: {}", _0)]

#[display(fmt = "Unexpected IO error: {}", _0)]

ascjones · 2019-06-17T06:12:24Z

@dvdplm just killed all those

* master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747)

…me-parent * master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)

* master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)

* master: Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)

…-even * master: [devp2p] Update to 2018 edition (#10716) Add a way to signal shutdown to snapshotting threads (#10744) Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)

…p/chore/aura-log-validator-set-in-epoch-manager * dp/chore/aura-warn-when-validators-is-1-or-even: [devp2p] Update to 2018 edition (#10716) Add a way to signal shutdown to snapshotting threads (#10744) Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) Update ethcore/src/engines/validator_set/simple_list.rs DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)

ascjones added 4 commits June 14, 2019 07:38

Replace error chain for network error

79d7611

Fix usages and add manual From impls

aa4f0fe

OnDemand Error and remove remaining dependencies

a0392b4

Die error_chain, die.

d2f5ed0

ascjones added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jun 14, 2019

dvdplm approved these changes Jun 14, 2019

View reviewed changes

dvdplm added the A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. label Jun 14, 2019

DIE

11868fe

ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jun 14, 2019

ordian approved these changes Jun 15, 2019

View reviewed changes

Comment thread util/network/src/error.rs Outdated

Hasta la vista, baby

7c34bc0

dvdplm reviewed Jun 17, 2019

View reviewed changes

dvdplm merged commit bf55db4 into master Jun 17, 2019

dvdplm deleted the aj-error-chain branch June 17, 2019 06:45

dvdplm added a commit that referenced this pull request Jun 17, 2019

Merge branch 'master' into dp/fix/abort-snapshots-hangs-shutdown

2d6088f

* master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747)

	#[display(fmt ="Failed to parse network address")]
	#[display(fmt = "Failed to parse network address")]

	#[display(fmt ="Failed to resolve network address {}", _0)]
	#[display(fmt = "Failed to resolve network address {}", _0)]

	#[display(fmt ="Authentication failure")]
	#[display(fmt = "Authentication failure")]

	#[display(fmt ="Bad protocol")]
	#[display(fmt = "Bad protocol")]

	#[display(fmt ="Expired message")]
	#[display(fmt = "Expired message")]

	#[display(fmt ="Invalid node id")]
	#[display(fmt = "Invalid node id")]

	#[display(fmt ="Packet is too large")]
	#[display(fmt = "Packet is too large")]

	#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")]
	#[display(fmt = "Too many open files in this process. Check your resource limits and restart parity")]

	#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]
	#[display(fmt = "Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")]

	#[display(fmt ="Unexpected IO error: {}", _0)]
	#[display(fmt = "Unexpected IO error: {}", _0)]

Conversation

ascjones commented Jun 14, 2019

Uh oh!

dvdplm left a comment

Choose a reason for hiding this comment

Uh oh!

ordian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dvdplm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ascjones commented Jun 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants