This repository was archived by the owner on Nov 6, 2020. It is now read-only.
CI improvements#10579
Merged
Merged
Conversation
|
It looks like @TriplEight signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
General-Beck
approved these changes
Apr 11, 2019
gabreal
approved these changes
Apr 12, 2019
Contributor
gabreal
left a comment
There was a problem hiding this comment.
looks also good to me. so there won't be tests for mac or win?
Collaborator
Author
@gabreal this is not decided yet, and will require changes on hosts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--verbose --color=alwaysartifacts:sections in one job, so forbuildstage logs will still be uploaded, but with the&collect_artifactsrule (on_successand1 mos).Another problem I thought was connected with caching, some tests were failing. At first I thought it's due to caching, but per-job isolation showed that it's not the caching problem.
As a bonus, we (with Niklas help) have found 2 flaky tests.