Stop breaking out of loop if a non-canonical hash is found#10566
Stop breaking out of loop if a non-canonical hash is found#10566HCastano wants to merge 1 commit into
Conversation
|
It looks like @HCastano signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
dvdplm
left a comment
There was a problem hiding this comment.
Code looks fine and collecting more data is warranted. Do we want the logging to remain indefinitely though? Or make a note to return to the previous code when we've figured this one out?
|
I don't think we need all the logging added here, but I think some additions in this area of the code wouldn't hurt (especially if they're at the |
|
@dvdplm Hey, sorry for the late reply, I haven't been checking Github all that often recently. It's basically just for debugging. It didn't end up solving the issue, but did provide some extra logs to look at. I think its fine if we close it without deleting it. |
Currently investigating #10085 with the help of @tomusdrw. We have a couple theories floating around, but we aren't sure how to reproduce them on our own.
We've narrowed down the cause to one of three function calls within
Blockchain::epoch_transition_for. This PR handles theNonecase of what we think is the most suspect function call better, as well as adds some additional logging so we can track where we are the loop.