Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

remove unused Engine::is_proposal#10475

Merged
ascjones merged 1 commit into
masterfrom
remove-is_proposal
Mar 14, 2019
Merged

remove unused Engine::is_proposal#10475
ascjones merged 1 commit into
masterfrom
remove-is_proposal

Conversation

@debris
Copy link
Copy Markdown
Collaborator

@debris debris commented Mar 14, 2019

remove is_proposal function and path that was never executed from client

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 14, 2019
@soc1c soc1c added this to the 2.5 milestone Mar 14, 2019
@debris debris requested review from ascjones and sorpaas March 14, 2019 11:58
Copy link
Copy Markdown
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally used in tendermint engine, but that's removed at this moment.

@sorpaas sorpaas added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 14, 2019
@ascjones ascjones merged commit f875175 into master Mar 14, 2019
@soc1c soc1c deleted the remove-is_proposal branch March 14, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants