Tests parallelized by TriplEight · Pull Request #10452 · openethereum/parity-ethereum

TriplEight · 2019-03-06T11:54:42Z

The example of new regular pipeline: https://gitlab.parity.io/parity/parity-ethereum/pipelines/32255

what's better

first stage now runs ~ 2 min
cargo test now runs ~ 16 min
whole pipeline takes ~ 19 min
now it's good to launch docker cache

what's changed

removed android-build from regular pipeline
split test.sh and test-all.sh by this whole lot of jobs
some stuff was optimized and simplified
nproc now counts threads for cargo test and cpp-test

reflections

it's really needed to overwrite the cpp-test
makes sense to think how to parallelize test.sh, maybe mark unit tests

parity-cla-bot · 2019-03-06T11:54:45Z

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

TriplEight · 2019-03-07T20:41:05Z

for now we are going to skip checking changed files, we are going to check them Gitlab way. But before that caching should be introduced.

TriplEight

right now CI is 10-30% faster

…um into tests_splitting

TriplEight · 2019-03-07T22:36:23Z

ready for the final review.

gabreal · 2019-03-11T10:35:27Z

great job, pipeline looks way more detailed and clear now

gabreal

well, pls go ahead with your pr. In general it looks very nice. About the thread cound I'm still sceptical, and I'm also still curious about the gitlab yaml changes feature.

* tests splitted, phase 1 * typo * fix wrong launch commands * typos * rearrangements * use `nproc` function for threads * use nproc for threads * let theads be auto, build-andriod no more in regular run * split val chain and cargo check * renamed some files * wrong phase * check rust files before test jobs * lint error * rust files modivied var * test except changes * add rust_changes except * lint error * fixes * .gitlab-ci.yml can't be excluded * pipeline shouldn't start * pipeline must go * pipeline must go 2 * pipeline must go 3 * pipeline must go 4 * pipeline must go 5 * pipeline must go 6 * pipeline must go 7 * pipeline must not go 1 * pipeline must go 8 * avoid skippng tests yet, reintroducing them after the caching * test theory * parallelized cargo check with combusting helicopters * less uploads * alias for cargo checks * nice template

* version: bump stable * CI publish to aws (#10446) * move publish aws from gitlab.yml to gitlab scripts * gitlab.yml cleaning move publish AWS to gitlab scripts remove dependencies from android build * Ensure static validator set changes are recognized (#10467) * CI aws git checkout (#10451) * Updating the CI system with the publication of releases and binary files on github Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * move publish aws from gitlab.yml to gitlab scripts Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * gitlab.yml cleaning move publish AWS to gitlab scripts remove dependencies from android build Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * Revert "Updating the CI system with the publication of releases and binary files on github" This reverts commit da87e06. * remove no-git for aws * microfix * no need in no_git then * Revert "CI aws git checkout (#10451)" (#10456) * Revert "CI aws git checkout (#10451)" This reverts commit 3e1d731. * Update .gitlab-ci.yml revert aws script with small fixes * Delete publish-aws.sh * Tests parallelized (#10452) * tests splitted, phase 1 * typo * fix wrong launch commands * typos * rearrangements * use `nproc` function for threads * use nproc for threads * let theads be auto, build-andriod no more in regular run * split val chain and cargo check * renamed some files * wrong phase * check rust files before test jobs * lint error * rust files modivied var * test except changes * add rust_changes except * lint error * fixes * .gitlab-ci.yml can't be excluded * pipeline shouldn't start * pipeline must go * pipeline must go 2 * pipeline must go 3 * pipeline must go 4 * pipeline must go 5 * pipeline must go 6 * pipeline must go 7 * pipeline must not go 1 * pipeline must go 8 * avoid skippng tests yet, reintroducing them after the caching * test theory * parallelized cargo check with combusting helicopters * less uploads * alias for cargo checks * nice template * Fix `ci-skip-issue` name * Fix build flag * Remove ci-skip-tests flag for stable

* version: bump beta * Implement parity_versionInfo & parity_setChain on LC; fix parity_setChain (#10312) * Light client: implement parity_versionInfo RPC * Light client: implement set_exit_handler & parity_setChain RPC * parity_setChain RPC: return an error if failed (instead of `true`) * Implement eth_subscribe('syncing') RPC for full node & light node * Fix indentation * Revert commit: Implement eth_subscribe('syncing') * Revert change to Cr callback function * CI publish to aws (#10446) * move publish aws from gitlab.yml to gitlab scripts * gitlab.yml cleaning move publish AWS to gitlab scripts remove dependencies from android build * CI aws git checkout (#10451) * Updating the CI system with the publication of releases and binary files on github Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * move publish aws from gitlab.yml to gitlab scripts Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * gitlab.yml cleaning move publish AWS to gitlab scripts remove dependencies from android build Signed-off-by: Denis S. Soldatov aka General-Beck <general.beck@gmail.com> * Revert "Updating the CI system with the publication of releases and binary files on github" This reverts commit da87e06. * remove no-git for aws * microfix * no need in no_git then * Revert "CI aws git checkout (#10451)" (#10456) * Revert "CI aws git checkout (#10451)" This reverts commit 3e1d731. * Update .gitlab-ci.yml revert aws script with small fixes * Delete publish-aws.sh * Tests parallelized (#10452) * tests splitted, phase 1 * typo * fix wrong launch commands * typos * rearrangements * use `nproc` function for threads * use nproc for threads * let theads be auto, build-andriod no more in regular run * split val chain and cargo check * renamed some files * wrong phase * check rust files before test jobs * lint error * rust files modivied var * test except changes * add rust_changes except * lint error * fixes * .gitlab-ci.yml can't be excluded * pipeline shouldn't start * pipeline must go * pipeline must go 2 * pipeline must go 3 * pipeline must go 4 * pipeline must go 5 * pipeline must go 6 * pipeline must go 7 * pipeline must not go 1 * pipeline must go 8 * avoid skippng tests yet, reintroducing them after the caching * test theory * parallelized cargo check with combusting helicopters * less uploads * alias for cargo checks * nice template * Ensure static validator set changes are recognized (#10467)

tests splitted, phase 1

44b1edc

TriplEight added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Mar 6, 2019

TriplEight self-assigned this Mar 6, 2019

TriplEight and others added 9 commits March 6, 2019 13:00

typo

403ee7b

fix wrong launch commands

fe585ac

typos

b2b1bc2

rearrangements

e76f4da

use nproc function for threads

c66f5ae

use nproc for threads

5d523cf

let theads be auto, build-andriod no more in regular run

69a62a6

nproc threading

b98430b

split val chain and cargo check

12ff729

TriplEight changed the title ~~WIP: tests splitted, phase 1~~ Tests parallelized Mar 6, 2019

TriplEight removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Mar 6, 2019

TriplEight requested review from General-Beck, gabreal, kirushik and soc1c March 6, 2019 17:20

General-Beck approved these changes Mar 6, 2019

View reviewed changes

General-Beck added A0-pleasereview 🤓 Pull request needs code review. F4-tests 💻 Tests need fixing, improving or augmenting. M1-ci 🙉 Continuous integration. labels Mar 6, 2019

gabreal suggested changes Mar 7, 2019

View reviewed changes

Comment thread .gitlab-ci.yml Outdated

Comment thread .gitlab-ci.yml Outdated

Comment thread .gitlab-ci.yml Outdated

Comment thread .gitlab-ci.yml Outdated

Comment thread .gitlab-ci.yml Outdated

Comment thread scripts/gitlab/test-cpp.sh

TriplEight and others added 6 commits March 7, 2019 15:13

renamed some files

02a6286

wrong phase

13391e2

check rust files before test jobs

dfd422b

lint error

9fd520f

rust files modivied var

2dfc800

test except changes

544a263

TriplEight added 3 commits March 7, 2019 20:50

pipeline must go 7

190ed90

pipeline must not go 1

24dbdb5

pipeline must go 8

e4f38ca

soc1c added this to the 2.5 milestone Mar 7, 2019

soc1c added B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Mar 7, 2019

avoid skippng tests yet, reintroducing them after the caching

50a27b8

TriplEight commented Mar 7, 2019

View reviewed changes

Comment thread .gitlab-ci.yml Outdated

Comment thread scripts/gitlab/test-cpp.sh

soc1c reviewed Mar 7, 2019

View reviewed changes

Comment thread accounts/ethkey/src/brain.rs Outdated

TriplEight and others added 6 commits March 7, 2019 21:59

Merge branch 'master' into tests_splitting

9b4a3d1

test theory

d169e7b

Merge branch 'tests_splitting' of github.com:paritytech/parity-ethere…

b1a7937

…um into tests_splitting

parallelized cargo check with combusting helicopters

afbe8b4

less uploads

06e8b1e

alias for cargo checks

539047a

gabreal self-requested a review March 11, 2019 10:05

gabreal reviewed Mar 11, 2019

View reviewed changes

nice template

2c78082

gabreal approved these changes Mar 11, 2019

View reviewed changes

Comment thread .gitlab-ci.yml Outdated

Comment thread scripts/gitlab/rust-changes.sh

TriplEight merged commit 82a148a into master Mar 11, 2019

soc1c deleted the tests_splitting branch March 12, 2019 10:57

soc1c mentioned this pull request Mar 13, 2019

2.3.6 stable backports #10470

Merged

6 tasks

soc1c mentioned this pull request Mar 13, 2019

2.4.1 beta backports #10471

Merged

7 tasks

Conversation

TriplEight commented Mar 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what's better

what's changed

reflections

Uh oh!

parity-cla-bot commented Mar 6, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TriplEight commented Mar 7, 2019

Uh oh!

TriplEight left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TriplEight commented Mar 7, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabreal commented Mar 11, 2019

Uh oh!

gabreal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TriplEight commented Mar 6, 2019 •

edited

Loading