This repository was archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
revert some changes, could be buggy #10399
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6018089
no-git for publish jobs, empty artifacts dir
TriplEight a2407a3
fix syntax
TriplEight cc0c8f3
prettiness
TriplEight 8a66196
fix prettiness
TriplEight 518c9d9
should get rid of git in publishing
TriplEight a62b940
should get rid of git in publishing, some fixes
TriplEight 1268855
can't drop git in publish jobs yet
TriplEight 88ce554
Merge branch 'master' into fix-ci_307
TriplEight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ variables: | |
| when: on_success | ||
| expire_in: 1 mos | ||
| paths: | ||
| - artifacts/ | ||
| - artifacts/ | ||
|
|
||
| .determine_version: &determine_version | ||
| - VERSION="$(sed -r -n '1,/^version/s/^version = "([^"]+)".*$/\1/p' Cargo.toml)" | ||
|
|
@@ -99,7 +99,7 @@ build-windows: | |
| publish-docker: | ||
| stage: publish | ||
| only: *releaseable_branches | ||
| <<: *no_git | ||
| # <<: *no_git | ||
| cache: {} | ||
| dependencies: | ||
| - build-linux | ||
|
|
@@ -129,7 +129,7 @@ publish-snap: | |
| publish-onchain: | ||
| stage: publish | ||
| only: *releaseable_branches | ||
| <<: *no_git | ||
| # <<: *no_git | ||
| cache: {} | ||
| dependencies: | ||
| - build-linux | ||
|
|
@@ -140,23 +140,6 @@ publish-onchain: | |
| tags: | ||
| - linux-docker | ||
|
|
||
| # configures aws for fast uploads/syncs | ||
| .s3-before-script: &s3-before-script | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this being removed?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. moved to docker parity/awscli @TriplEight ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's here now |
||
| before_script: | ||
| - mkdir -p ${HOME}/.aws | ||
| - | | ||
| cat > ${HOME}/.aws/config <<EOC | ||
| [default] | ||
| s3 = | ||
| max_concurrent_requests = 20 | ||
| max_queue_size = 10000 | ||
| multipart_threshold = 64MB | ||
| multipart_chunksize = 16MB | ||
| max_bandwidth = 50MB/s | ||
| use_accelerate_endpoint = false | ||
| addressing_style = path | ||
| EOC | ||
|
|
||
| publish-awss3-release: | ||
| image: parity/awscli:latest | ||
| stage: publish | ||
|
|
@@ -167,9 +150,6 @@ publish-awss3-release: | |
| - build-linux | ||
| - build-darwin | ||
| - build-windows | ||
| variables: | ||
| GIT_STRATEGY: none | ||
| <<: *s3-before-script | ||
| script: | ||
| - echo "__________Push binaries to AWS S3____________" | ||
| - case "${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}" in | ||
|
|
@@ -185,10 +165,11 @@ publish-awss3-release: | |
| - aws s3 ls s3://${BUCKET}/${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}/ | ||
| --recursive --human-readable --summarize | ||
| tags: | ||
| - linux-docker | ||
| - linux-docker | ||
|
|
||
| publish-docs: | ||
| stage: publish | ||
| # <<: *no_git | ||
| only: | ||
| - tags | ||
| except: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove it or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove