snap: reenable i386, arm64, armhf architecture publishing by 5chdn · Pull Request #10386 · openethereum/parity-ethereum

5chdn · 2019-02-20T11:46:54Z

No description provided.

TriplEight · 2019-02-20T14:06:25Z

not sure though, if all these builds can be done in the same Docker image, have to check first.

General-Beck · 2019-02-21T10:11:18Z

@ElOpio any ideas? https://gitlab.parity.io/parity/parity-ethereum/-/jobs/124182
other tasks with other architectures were built successfully

5chdn · 2019-02-21T10:41:21Z

@General-Beck this also fails on nightly, so probably unrelated

TriplEight

ready to merge,
publish-snap issue resolved

soc1c · 2019-02-22T10:35:16Z


-image:                             parity/rust:gitlab-ci
-
+image:                             parity/rust-parity-ethereum-build:xenial


what's the logic behind changing this now?

this docker image has been tested,
it's the preparation for using cache in docker volumes

new CI images

soc1c · 2019-02-22T10:35:27Z

      - artifacts/

-.determine_version:                &determine_version
-  - VERSION="$(sed -r -n '1,/^version/s/^version = "([^"]+)".*$/\1/p' Cargo.toml)"


Why is this removed?

was used only in publish-snap.sh so moved there.
Is there a reason for it to stay here?

used only for publish snap

soc1c · 2019-02-22T10:35:51Z

    - build-linux
  tags:
-    - rust-stable
+    - linux-docker


Why linux-docker?

clean up the tags

soc1c · 2019-02-22T10:36:45Z

-  else
-    ./parity tools hash $binary > $binary.sha3
-  fi
+  rhash --sha256 $binary -o $binary.sha256 #do we still need this hash (SHA2)?


SHA256 is used for Vanity Service and Homebrew (Releases) And One-line Installer

soc1c · 2019-02-22T10:37:27Z

+# prepare variables
+VERSION=v"$(sed -r -n '1,/^version/s/^version = "([^"]+)".*$/\1/p' Cargo.toml)"
+SNAP_PACKAGE="parity_"$VERSION"_"$BUILD_ARCH".snap"
+CARGO_TARGET="$(ls artifacts)"


What? ls artifacts gives a reliable CARGO_TARGET?

yes, from artifacts dir

soc1c · 2019-02-22T10:38:25Z

      cp -v ethkey $SNAPCRAFT_PART_INSTALL/usr/bin/ethkey
      cp -v ethstore $SNAPCRAFT_PART_INSTALL/usr/bin/ethstore
      cp -v whisper $SNAPCRAFT_PART_INSTALL/usr/bin/whisper
-    stage-packages: [libc6, libudev1, libstdc++6, cmake, libdb5.3]


we added libc6 because it was failling without. It's working now?

and it was the reason it failed here: https://github.com/paritytech/devops/issues/307

gabreal

haven't checked the snap config

gabreal · 2019-02-22T11:06:43Z

-    ./parity tools hash $binary > $binary.sha3
-  fi
+  rhash --sha256 $binary -o $binary.sha256 #do we still need this hash (SHA2)?
+  rhash --sha3-256 $binary -o $binary.sha3


hashes are different, is that okay?

% target/release/parity tools hash target/release/parity 58b49924c583b45871cac4077da8f99820a684df8cca9a81c742080e991f671d % rhash --sha3-256 target/release/parity 95fcba97a2059bbae16f997c3ea7b6c6c0f9ef5990313f55eb8536a1b3bef9e3 target/release/parity % rhash --sha256 target/release/parity 19c7ac31b99f5a45e6a4236367df18467321a3fc9f492c19f80cede098d47abf target/release/parity

we can't use parity to calculate the hash for other architectures

gabreal · 2019-02-22T11:08:49Z


-image:                             parity/rust:gitlab-ci
-
+image:                             parity/rust-parity-ethereum-build:xenial


would prefer a separate pr for that, just in case one has to revert.

soc1c · 2019-02-22T14:29:38Z

Needs a 2nd review.

TriplEight · 2019-02-22T14:53:10Z

android parity-clib compiles now: https://gitlab.parity.io/parity/parity-ethereum/pipelines/31445

TriplEight · 2019-02-22T16:30:56Z

The latest pipeline is all green: https://gitlab.parity.io/parity/parity-ethereum/pipelines/31461

…um#10386) * snap: reenable i386, arm64, armhf architecture publishing * gitlab: fix indent * gitlab: fix yml syntax * Linker for crosscomile * fix target to linker * new docker image * fix lint, add build to this PR * calc SHA3 using rhash * add new images for i386, armhf * show snap target & artifacts * set CARGO_TARGET for publish snap * move detect Version to publish snap * rm libc6 dep from snap-template up pub-snap script * clean up cargo config before add linker * move linker config to docker images

* no-git for publish jobs, empty artifacts dir (#10393) * no-git for publish jobs, empty artifacts dir * fix syntax * prettiness * fix prettiness * should get rid of git in publishing * snap: reenable i386, arm64, armhf architecture publishing (#10386) * snap: reenable i386, arm64, armhf architecture publishing * gitlab: fix indent * gitlab: fix yml syntax * Linker for crosscomile * fix target to linker * new docker image * fix lint, add build to this PR * calc SHA3 using rhash * add new images for i386, armhf * show snap target & artifacts * set CARGO_TARGET for publish snap * move detect Version to publish snap * rm libc6 dep from snap-template up pub-snap script * clean up cargo config before add linker * move linker config to docker images * tx pool: always accept local transactions (#10375) * tx pool: always accept local transactions * tx pool: `choose` local txs with same sender and nonce * Fix to_pod storage trie value decoding (#10368)

* no-git for publish jobs, empty artifacts dir (#10393) * no-git for publish jobs, empty artifacts dir * fix syntax * prettiness * fix prettiness * should get rid of git in publishing * Fix to_pod storage trie value decoding (#10368) * snap: reenable i386, arm64, armhf architecture publishing (#10386) * snap: reenable i386, arm64, armhf architecture publishing * gitlab: fix indent * gitlab: fix yml syntax * Linker for crosscomile * fix target to linker * new docker image * fix lint, add build to this PR * calc SHA3 using rhash * add new images for i386, armhf * show snap target & artifacts * set CARGO_TARGET for publish snap * move detect Version to publish snap * rm libc6 dep from snap-template up pub-snap script * clean up cargo config before add linker * move linker config to docker images

snap: reenable i386, arm64, armhf architecture publishing

61f5e1e

5chdn added A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration. labels Feb 20, 2019

5chdn added this to the 2.4 milestone Feb 20, 2019

TriplEight suggested changes Feb 20, 2019

View reviewed changes

Comment thread .gitlab-ci.yml Outdated

Comment thread .gitlab-ci.yml

5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Feb 20, 2019

5chdn added 2 commits February 20, 2019 13:15

gitlab: fix indent

02116dd

gitlab: fix yml syntax

46eefcb

5chdn added B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Feb 20, 2019

TriplEight approved these changes Feb 20, 2019

View reviewed changes

5chdn added A8-looksgood 🦄 Pull request is reviewed well. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 20, 2019

General-Beck added 7 commits February 20, 2019 18:49

Linker for crosscomile

ba4ca7b

fix target to linker

66d003b

new docker image

76a14d7

fix lint, add build to this PR

62fd60a

calc SHA3 using rhash

59fb257

add new images for i386, armhf

655f925

show snap target & artifacts

da071cb

General-Beck self-assigned this Feb 20, 2019

set CARGO_TARGET for publish snap

6c0fff2

5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019

5chdn modified the milestones: 2.6, 2.5 Feb 21, 2019

General-Beck and others added 3 commits February 21, 2019 23:06

move detect Version to publish snap

15a88da

rm libc6 dep from snap-template up pub-snap script

eae7ef1

Merge branch 'master' into a5-snap-archs

4f0de83

TriplEight requested review from TriplEight, ddorgan, fevo1971 and gabreal February 22, 2019 09:10

TriplEight approved these changes Feb 22, 2019

View reviewed changes

soc1c reviewed Feb 22, 2019

View reviewed changes

gabreal reviewed Feb 22, 2019

View reviewed changes

General-Beck added 2 commits February 22, 2019 15:02

clean up cargo config before add linker

e3a7364

move linker config to docker images

33e7a12

soc1c removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Feb 22, 2019

soc1c added the B9-blocker 🚧 This pull request blocks the next release from happening. Use only in extreme cases. label Feb 25, 2019

ddorgan approved these changes Feb 25, 2019

View reviewed changes

General-Beck merged commit bceb883 into master Feb 25, 2019

General-Beck deleted the a5-snap-archs branch February 25, 2019 11:57


		image: parity/rust:gitlab-ci

		image: parity/rust-parity-ethereum-build:xenial

Conversation

5chdn commented Feb 20, 2019

Uh oh!

Uh oh!

Uh oh!

TriplEight commented Feb 20, 2019

Uh oh!

General-Beck commented Feb 21, 2019

Uh oh!

5chdn commented Feb 21, 2019

Uh oh!

TriplEight left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gabreal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soc1c commented Feb 22, 2019

Uh oh!

TriplEight commented Feb 22, 2019

Uh oh!

TriplEight commented Feb 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants