This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Refactor ethcore::client::TransactResult to use it inside std::result::Result#10366
Merged
Conversation
|
It looks like @elferdo signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
sorpaas
approved these changes
Feb 25, 2019
sorpaas
added
A8-looksgood 🦄
sorpaas
approved these changes
Feb 25, 2019
debris
approved these changes
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethcore::client::TransactResultlooks similar tostd::result::Resultbut its functionality is actually not comparable.This PR separates the
Okand theErrvariants ofethcore::client::TransactResultintostruct TransactSuccessandstruct TransactErrto be used inside the respective variants ofstd::result::Result.Fixes: #8755