Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fixed misstype#10351

Merged
HCastano merged 2 commits into
openethereum:masterfrom
danacr:patch-1
Feb 14, 2019
Merged

Fixed misstype#10351
HCastano merged 2 commits into
openethereum:masterfrom
danacr:patch-1

Conversation

@danacr
Copy link
Copy Markdown
Contributor

@danacr danacr commented Feb 14, 2019

BadTransactonType => BadTransactionType

@danacr
Fixed misstype
f765443 
BadTransactonType => BadTransactionType
@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Feb 14, 2019

It looks like @danacr hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@danacr
Copy link
Copy Markdown
Contributor Author

danacr commented Feb 14, 2019

[clabot:check]

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Feb 14, 2019

It looks like @danacr signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@HCastano
Copy link
Copy Markdown
Contributor

HCastano commented Feb 14, 2019

@danacr There are a few other places in the code where this is misspelled. Would you mind going through and fixing the others as well?

@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Feb 14, 2019
@niklasad1 niklasad1 added this to the 2.4 milestone Feb 14, 2019
@HCastano HCastano added M4-core ⛓ Core client code / Rust. and removed M4-core ⛓ Core client code / Rust. labels Feb 14, 2019
@HCastano HCastano merged commit d6c80c1 into openethereum:master Feb 14, 2019
ordian added a commit that referenced this pull request Apr 5, 2019
@ordian
Merge branch 'master' into ao-lmdb
0695f94 
* master:
  no volumes are needed, just run -v volume:/path/in/the/container (#10345)
  Fixed misstype (#10351)
  snap: prefix version and populate candidate channel (#10343)
  Bundle protocol and packet_id together in chain sync (#10315)
  role back docker build image and docker deploy image to ubuntu:xenial based (#10338)
  change docker image based on debian instead of ubuntu due to the chan… (#10336)
  Don't add discovery initiators to the node table (#10305)
  fix(docker): fix not receives SIGINT (#10059)
  snap: official image / test (#10168)
  fix(add helper for timestamp overflows) (#10330)
  Additional error for invalid gas (#10327)
  Revive parity_setMinGasPrice RPC call (#10294)
  Add Statetest support for Constantinople Fix (#10323)
  fix(parity-clib): grumbles that were not addressed in #9920 (#10154)
  fix(light-rpc): Make `light_sync` generic (#10238)
  fix publish job (#10317)
  Secure WS-RPC: grant access to all apis (#10246)
  Make specification of protocol in SyncRequester::send_request explicit (#10295)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@HCastano HCastano HCastano approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Milestone

2.4

Development

Successfully merging this pull request may close these issues.

4 participants

@danacr @parity-cla-bot @HCastano @niklasad1