Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

fix(osx and windows builds): bump parity-daemonize#10291

Merged
5chdn merged 1 commit into
masterfrom
bump-parity-daemonize
Feb 7, 2019
Merged

fix(osx and windows builds): bump parity-daemonize#10291
5chdn merged 1 commit into
masterfrom
bump-parity-daemonize

Conversation

@niklasad1
Copy link
Copy Markdown
Collaborator

Attempt to fix Windows and OSX builds

/cc @5chdn @ddorgan can you help me run this on Windows and OSX? Thanks

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M0-build 🏗 Building and build system. labels Feb 4, 2019
@HCastano
Copy link
Copy Markdown
Contributor

HCastano commented Feb 4, 2019

Looks like it's building fine on my Mac now.

@niklasad1
Copy link
Copy Markdown
Collaborator Author

It fails because of the CI is running rust 1.31.1, see rust-lang/rust#53130. Thus, it is fixed in rust 1.32

If we can bump to rust 1.32 it would be find or any objections that we should support earlier rust versions?

@5chdn
Copy link
Copy Markdown
Contributor

5chdn commented Feb 4, 2019

why is CI using outdated rust versions @fevo1971 ?

@fevo1971
Copy link
Copy Markdown
Contributor

fevo1971 commented Feb 5, 2019

why is CI using outdated rust versions @fevo1971 ?

on mac & windows rust is updated daylay (at ~23:00h), for the docker image parity/rust:gitlab-ci used for all other builds this is not the case (embarrassingly for some quite some time). i coordinated with @TriplEight to finish his work on the new docker image (based on the rust:stable image).

@niklasad1
Copy link
Copy Markdown
Collaborator Author

niklasad1 commented Feb 6, 2019

FYI, I've built android successfully locally, log here

Thus, the android pipeline runs also an old version of Rust.

@fevo1971 can you confirm if that is true? thanks 🚀

@ordian ordian added this to the 2.4 milestone Feb 6, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 6, 2019
@niklasad1 niklasad1 force-pushed the bump-parity-daemonize branch from 6caab1f to 42f3d6c Compare February 6, 2019 17:18
@5chdn 5chdn merged commit e45ee6c into master Feb 7, 2019
@5chdn 5chdn deleted the bump-parity-daemonize branch February 7, 2019 11:53
ordian added a commit that referenced this pull request Apr 5, 2019
* master:
  fix: parity-clib/examples/cpp/CMakeLists.txt (#10313)
  CI optimizations (#10297)
  Increase number of requested block bodies in chain sync (#10247)
  Deprecate account management (#10213)
  Properly handle check_epoch_end_signal errors (#10015)
  fix(osx and windows builds): bump parity-daemonize (#10291)
  Add missing step for  Using `systemd` service file (#10175)
  Call private contract methods from another private contract (read-only)  (#10086)
  update ring to 0.14 (#10262)
  fix(secret-store): deprecation warning (#10301)
  Update to jsonrpc-derive 10.0.2, fixes aliases bug (#10300)
  Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants