This repository was archived by the owner on Nov 6, 2020. It is now read-only.
fix(rpc-types/hash): make Copy to unify with ethereum-types#10196
Closed
niklasad1 wants to merge 1 commit into
Closed
fix(rpc-types/hash): make Copy to unify with ethereum-types#10196niklasad1 wants to merge 1 commit into
Copy to unify with ethereum-types#10196niklasad1 wants to merge 1 commit into
Conversation
The crates ethereum-types and ethbloom their types are `Copy` and `Rpc Hash/Uint` and based on those types so it more convient to have the same properties as those.
niklasad1
added
A0-pleasereview 🤓
Collaborator
|
@niklasad1 aren't the types in |
Collaborator
Author
|
@tomusdrw Yeah, they do. I can check how painful it is to remove those RPC wrappers. |
Collaborator
Author
|
Closed in favor of #10217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crates
ethereum-typesandethbloomtheir types areCopyandRpc Hash/Uintand based on those types so it is more convenient to have the same properties as those.