This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Update for Android cross-compilation.#10180
Merged
Merged
Conversation
|
It looks like @TriplEight signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
TriplEight
force-pushed
the
android_CI
branch
from
aa87761 to
eb2170a
Compare
Collaborator
Author
Collaborator
|
@TriplEight shouldn't we link with |
Collaborator
Author
|
@niklasad1 thanks for the tip, the linker you've mentioned was used, but incorrectly added in the Dockerfile. |
gabreal
reviewed
Jan 15, 2019
Contributor
gabreal
left a comment
gabreal
left a comment
There was a problem hiding this comment.
How come only the parity-clib target is needed for android?
And I guess the cargo config files will be included in the docker containers then?
add android postprocessing
tomaka
reviewed
Jan 15, 2019
| if [ "${CARGO_TARGET}" = "armv7-linux-androideabi" ] | ||
| then | ||
| # only thing we need for android | ||
| cp -v ../../target/$CARGO_TARGET/release/parity ./parity-clib |
Contributor
There was a problem hiding this comment.
That would be libparity.so, not parity.
libparity.so
General-Beck
approved these changes
Jan 15, 2019
General-Beck
added
A0-pleasereview 🤓
5chdn
added
B1-patch-beta 🕷🕷
B0-patch-stable 🕷
gabreal
approved these changes
Jan 15, 2019
This was referenced Jan 21, 2019
Merged
5chdn
pushed a commit
that referenced
this pull request
Jan 22, 2019
* build-unix update * .gitlab-ci update * Update build-unix.sh add android postprocessing * path to android lib libparity.so * fix path to libparity * add android lib to artifacts
5chdn
pushed a commit
that referenced
this pull request
Jan 22, 2019
* build-unix update * .gitlab-ci update * Update build-unix.sh add android postprocessing * path to android lib libparity.so * fix path to libparity * add android lib to artifacts
5chdn
added a commit
that referenced
this pull request
Jan 22, 2019
* version: bump stable to 2.2.8 * Update for Android cross-compilation. (#10180) * build-unix update * .gitlab-ci update * Update build-unix.sh add android postprocessing * path to android lib libparity.so * fix path to libparity * add android lib to artifacts * Cancel Constantinople HF on POA Core (#10198) * Add EIP-1283 disable transition (#10214) * Enable St-Peters-Fork ("Constantinople Fix") (#10223) * ethcore: disable eip-1283 on kovan block 10255201 * ethcore: disable eip-1283 on ropsten block 4939394 * ethcore: enable st-peters-fork on mainnet block 7280000 * ethcore: fix kovan chain spec * version: update fork blocks * ethcore: disable eip-1283 on sokol block 7026400
5chdn
added a commit
that referenced
this pull request
Jan 22, 2019
* version: bump beta to 2.3.1 * Fix _cannot recursively call into `Core`_ issue (#10144) * Change igd to github:maufl/rust-igd * Run `igd::search_gateway_from_timeout` from own thread * Update for Android cross-compilation. (#10180) * build-unix update * .gitlab-ci update * Update build-unix.sh add android postprocessing * path to android lib libparity.so * fix path to libparity * add android lib to artifacts * Run all `igd` methods in its own thread (#10195) * Cancel Constantinople HF on POA Core (#10198) * Add EIP-1283 disable transition (#10214) * Enable St-Peters-Fork ("Constantinople Fix") (#10223) * ethcore: disable eip-1283 on kovan block 10255201 * ethcore: disable eip-1283 on ropsten block 4939394 * ethcore: enable st-peters-fork on mainnet block 7280000 * ethcore: fix kovan chain spec * version: update fork blocks * ethcore: disable eip-1283 on sokol block 7026400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @tomaka , could you take a look at the changes in the script.
Unfortunately, there's nothing can be done with this monstrous Dockerfile: https://github.com/paritytech/scripts/blob/master/docker-files-for-Gitlab-CI-rust/cross/android/Dockerfile (size: 4111). I've also updated and pushed it to the docker hub.