This repository was archived by the owner on Nov 6, 2020. It is now read-only.
backports for 2.3.0 beta#10164
Merged
Merged
Conversation
5chdn
added
A3-inprogress ⏳
5chdn
added
A0-pleasereview 🤓
tomusdrw
approved these changes
Jan 15, 2019
| foundation = { forkBlock = 4370000, critical = false } | ||
| ropsten = { forkBlock = 4230000, critical = false } | ||
| kovan = { forkBlock = 6600000, critical = false } | ||
| foundation = { forkBlock = 4370000, critical = true } |
Collaborator
There was a problem hiding this comment.
forkBlock most likely needs an update
| ropsten = { forkBlock = 4230000, critical = false } | ||
| kovan = { forkBlock = 6600000, critical = false } | ||
| foundation = { forkBlock = 4370000, critical = true } | ||
| ropsten = { forkBlock = 4230000, critical = true } |
Collaborator
There was a problem hiding this comment.
Why is it critical on testnets? Because of #10167 ?
Contributor
Author
There was a problem hiding this comment.
Yes, we might need a better definition of critical here
…ith storage items (#10065) * Add is_base_storage_root_unchanged * Fix compile, use a shortcut for check, and remove ignored tests * Add a warn! * Update ethereum/tests to v6.0.0-beta.2 * grumble: use {:#x} instead of 0x{:x} Co-Authored-By: sorpaas <accounts@that.world>
niklasad1
approved these changes
Jan 15, 2019
* ethcore: pull constantinople on ethereum network * version: mark update as critical * ethcore: remove constantinople alltogether from chain spec * version: revert fork block for ethereum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coreissue (Fix _cannot recursively call intoCore_ issue #10144)