Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

backports for stable 2.2.7#10163

Merged
5chdn merged 10 commits into
stablefrom
a5-stable-227
Jan 15, 2019
Merged

backports for stable 2.2.7#10163
5chdn merged 10 commits into
stablefrom
a5-stable-227

Conversation

@5chdn
Copy link
Copy Markdown
Contributor

@5chdn 5chdn commented Jan 10, 2019 •
edited
Loading

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. A8-backport 🕸 Pull request is already reviewed well in another branch. labels Jan 10, 2019
@5chdn 5chdn added this to the Patch milestone Jan 10, 2019
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 10, 2019
5chdn and others added 3 commits January 12, 2019 17:40
@5chdn
snap: fix path in script (#10157)
c0e7838 
* snap: fix path in script

* debug, revert me

* fix

* necromancer awk magic

* awk necromancy and path fixing

* working track selection
@ngotchac @5chdn
Fix _cannot recursively call into Core_ issue (#10144)
f8bbd3f 
* Change igd to github:maufl/rust-igd

* Run `igd::search_gateway_from_timeout` from own thread
@sorpaas @niklasad1
Handle the case for contract creation on an empty but exist account w…
9bcc2fc 
…ith storage items (#10065)

* Add is_base_storage_root_unchanged

* Fix compile, use a shortcut for check, and remove ignored tests

* Add a warn!

* Update ethereum/tests to v6.0.0-beta.2

* grumble: use {:#x} instead of 0x{:x}

Co-Authored-By: sorpaas <accounts@that.world>
5chdn added 2 commits January 15, 2019 15:50
@5chdn
version: bump fork blocks for kovan and foundation (#10186)
b91be14
@5chdn
pull constantinople on ethereum network (#10189)
6bd2ee9 
* ethcore: pull constantinople on ethereum network

* version: mark update as critical

* ethcore: remove constantinople alltogether from chain spec

* version: revert fork block for ethereum
@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Jan 15, 2019
@5chdn 5chdn merged commit b00a21f into stable Jan 15, 2019
@5chdn 5chdn deleted the a5-stable-227 branch January 15, 2019 21:26
@kirushik
Copy link
Copy Markdown
Collaborator

kirushik commented Jan 15, 2019

We're not shipping android versions ATM, so gitlab-build-android can be safely ignored; there's a clear CI misconfiguration.

@TriplEight something for you to look at, most probably

@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Jan 15, 2019

it's fixed already but not backported afaik @kirushik

@kirushik
Copy link
Copy Markdown
Collaborator

kirushik commented Jan 15, 2019

OK, I see

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.

Projects

None yet

Milestone

Patch

Development

Successfully merging this pull request may close these issues.

5 participants

@5chdn @kirushik @niklasad1 @ngotchac @sorpaas