Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fix a trace filter panic#10145

Merged
sorpaas merged 1 commit into
openethereum:masterfrom
cheme:avoid_it_panic
Jan 7, 2019
Merged

Fix a trace filter panic#10145
sorpaas merged 1 commit into
openethereum:masterfrom
cheme:avoid_it_panic

Conversation

@cheme
Copy link
Copy Markdown
Contributor

@cheme cheme commented Jan 7, 2019

This pr fix #10091 by making the file iterator over bloom empty when the position is too big.

@parity-cla-bot
Copy link
Copy Markdown

It looks like @cheme signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

Copy link
Copy Markdown
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sorpaas sorpaas merged commit 589083a into openethereum:master Jan 7, 2019
@5chdn 5chdn added this to the 2.3 milestone Jan 8, 2019
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trace_filter: incorrect argument leads node to crash

5 participants