Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Remove caching for node permissioning check#10143

Merged
ascjones merged 1 commit into
masterfrom
NodePermissioningOptimisation
Jan 8, 2019
Merged

Remove caching for node permissioning check#10143
ascjones merged 1 commit into
masterfrom
NodePermissioningOptimisation

Conversation

@grbIzl
Copy link
Copy Markdown
Collaborator

@grbIzl grbIzl commented Jan 7, 2019

LRU cache for checking nodes connectivity permissioning removed.

Copy link
Copy Markdown
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd be more in favour of more sophisticated cache though, cause now most likely state access will become the bottleneck.

@5chdn 5chdn added this to the 2.3 milestone Jan 7, 2019
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Jan 7, 2019
@ascjones ascjones merged commit 696dc05 into master Jan 8, 2019
@ascjones ascjones deleted the NodePermissioningOptimisation branch January 8, 2019 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants