Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

ethcore: update hardcoded headers#10123

Merged
sorpaas merged 8 commits into
masterfrom
a5-config-light
Jan 4, 2019
Merged

ethcore: update hardcoded headers#10123
sorpaas merged 8 commits into
masterfrom
a5-config-light

Conversation

@5chdn
Copy link
Copy Markdown
Contributor

@5chdn 5chdn commented Jan 2, 2019 •
edited
Loading

  • update hardcoded headers for Kovan #9918465
  • update hardcoded headers for Ropsten #4743169
  • update hardcoded headers for Ethereum #6993921
  • ensure consistent formatting across the chain specs
    • use tabs
    • remove unnecessary spaces
    • use hex over dec values
  • rename Kovan to "Kovan Testnet"
  • rename Ropsten to "Ropsten Testnet"
  • rename Foundation to "Ethereum"
  • move Ropsten from "test" to "ropsten" subdir

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. B1-patch-beta 🕷🕷 M2-config 📂 Chain specifications and node configurations. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Jan 2, 2019
@5chdn 5chdn added this to the 2.3 milestone Jan 2, 2019
This was referenced Jan 2, 2019
Merged
Merged
@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Jan 2, 2019

Light

❯ ./target/release/parity --chain ethereum --ports-shift 0 --light        
2019-01-02 15:04:09  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:04:09  Keys path /home/user/.local/share/io.parity.ethereum/keys/ethereum
2019-01-02 15:04:09  DB path /home/user/.local/share/io.parity.ethereum/chains_light/ethereum/db/906a34e69aec8c0d
2019-01-02 15:04:09  Running in experimental Light Client mode.
2019-01-02 15:04:09  Inserting hardcoded block #6993921 in chain
2019-01-02 15:04:10  Debug API is not available in light client mode.
2019-01-02 15:04:10  Debug API is not available in light client mode.
2019-01-02 15:04:10  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30303
2019-01-02 15:04:15  Syncing #6996070 0x669c…2f87   429.8 hdr/s   1688+    0 Qed  19/50 peers   1 MiB cache 1 MiB queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:04:17  Imported #6997944 0x4f12…22df (7.98 Mgas)
2019-01-02 15:04:19  Imported #6997950 0xcb88…4c74 (7.98 Mgas)
2019-01-02 15:04:25  Syncing #6997950 0xcb88…4c74   188.0 hdr/s      0+    0 Qed  18/50 peers   3 MiB cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:04:25  Imported #6997951 0xf88b…2014 (7.14 Mgas)

❯ ./target/release/parity --chain ropsten --ports-shift 100 --light        
2019-01-02 15:04:09  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:04:09  Keys path /home/user/.local/share/io.parity.ethereum/keys/ropsten
2019-01-02 15:04:09  DB path /home/user/.local/share/io.parity.ethereum/chains_light/ropsten/db/ae90623718e47d66
2019-01-02 15:04:09  Running in experimental Light Client mode.
2019-01-02 15:04:09  Inserting hardcoded block #4743169 in chain
2019-01-02 15:04:09  Debug API is not available in light client mode.
2019-01-02 15:04:09  Debug API is not available in light client mode.
2019-01-02 15:04:09  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30403
2019-01-02 15:04:39     2/50 peers   664 bytes cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:09     2/50 peers   664 bytes cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:19  Syncing #4743169 0xc04e…d00d     0.0 hdr/s      0+    0 Qed   3/50 peers   664 bytes cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:24  Syncing #4744193 0x3714…05bb   204.8 hdr/s      0+    0 Qed   4/50 peers   665 KiB cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:28  Imported #4745787 0xe562…dad3 (6.27 Mgas) + another 4 header(s)
2019-01-02 15:05:29  Syncing #4745793 0xd926…c157   320.0 hdr/s      0+    0 Qed   3/50 peers   2 MiB cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:34  Syncing #4745793 0xd926…c157     0.0 hdr/s      0+    0 Qed   3/50 peers   2 MiB cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:49  Syncing #4745793 0xd926…c157     0.0 hdr/s      0+    0 Qed   3/50 peers   2 MiB cache 0 bytes queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:05:50  Imported #4745795 0x3d21…44cc (2.49 Mgas) + another 1 header(s)

❯ ./target/release/parity --chain kovan --ports-shift 200 --light        
2019-01-02 15:04:09  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:04:09  Keys path /home/user/.local/share/io.parity.ethereum/keys/kovan
2019-01-02 15:04:09  DB path /home/user/.local/share/io.parity.ethereum/chains_light/kovan/db/9bf388941c25ea98
2019-01-02 15:04:09  Running in experimental Light Client mode.
2019-01-02 15:04:09  Inserting hardcoded block #9918465 in chain
2019-01-02 15:04:09  Debug API is not available in light client mode.
2019-01-02 15:04:09  Debug API is not available in light client mode.
2019-01-02 15:04:10  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30503
2019-01-02 15:04:15  Syncing #9921793 0xa4bc…d434   665.6 hdr/s      0+  256 Qed  13/50 peers   2 MiB cache 200 KiB queue  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:04:15  Imported #9922836 0x2901…cc84 (0.48 Mgas) + another 18 header(s)
2019-01-02 15:04:24  Imported #9922838 0x8745…f7d8 (0.43 Mgas) + another 1 header(s)
2019-01-02 15:04:29  Imported #9922839 0x7382…0f0d (0.34 Mgas

Full

❯ ./target/release/parity --chain ethereum --ports-shift 0 --no-warp
2019-01-02 15:07:17  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:07:17  Keys path /home/user/.local/share/io.parity.ethereum/keys/ethereum
2019-01-02 15:07:17  DB path /home/user/.local/share/io.parity.ethereum/chains/ethereum/db/906a34e69aec8c0d
2019-01-02 15:07:17  State DB configuration: fast
2019-01-02 15:07:17  Operating mode: active
2019-01-02 15:07:17  Configured for Ethereum using Ethash engine
2019-01-02 15:07:17  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30303
2019-01-02 15:07:18  Updated conversion rate to Ξ1 = US$155.09 (30704138 wei/gas)
2019-01-02 15:07:22  Syncing    #1023 0xd69e…598b   207.00 blk/s    0.0 tx/s    0.0 Mgas/s      0+    0 Qed     #1023    4/25 peers   1 MiB chain 9 MiB db 0 bytes queue 4 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:27  Syncing    #2421 0x6099…1998   279.40 blk/s    0.0 tx/s    0.0 Mgas/s   5949+    1 Qed     #8382    9/25 peers   2 MiB chain 13 MiB db 10 MiB queue 11 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:32  Syncing    #4125 0x2903…5896   341.00 blk/s    0.0 tx/s    0.0 Mgas/s   4242+    0 Qed     #8382   10/25 peers   4 MiB chain 23 MiB db 7 MiB queue 41 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:37  Syncing    #4853 0xd1ec…69a9   145.60 blk/s    0.0 tx/s    0.0 Mgas/s   3529+    0 Qed     #8386   10/25 peers   4 MiB chain 25 MiB db 6 MiB queue 44 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:42  Syncing    #5795 0x2f29…ad19   188.40 blk/s    0.0 tx/s    0.0 Mgas/s  26214+    0 Qed    #32013   11/25 peers   5 MiB chain 27 MiB db 40 MiB queue 29 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:47  Syncing    #7013 0x5112…7575   243.25 blk/s    0.0 tx/s    0.0 Mgas/s  26384+    0 Qed    #33401   14/25 peers   5 MiB chain 30 MiB db 40 MiB queue 30 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:52  Syncing    #8079 0x2cc7…c789   213.23 blk/s    0.0 tx/s    0.0 Mgas/s  25323+    0 Qed    #33404   16/25 peers   7 MiB chain 33 MiB db 38 MiB queue 41 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:57  Syncing    #9180 0xd772…b869   220.16 blk/s    0.0 tx/s    0.0 Mgas/s  37044+    0 Qed    #46229   18/25 peers   6 MiB chain 47 MiB db 56 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:02  Syncing   #10447 0x81d9…09d2   253.00 blk/s    0.0 tx/s    0.0 Mgas/s  35778+    0 Qed    #46229   20/25 peers   6 MiB chain 50 MiB db 54 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:07  Syncing   #11709 0x695d…8604   252.15 blk/s    0.0 tx/s    0.0 Mgas/s  34512+    0 Qed    #46229   21/25 peers   5 MiB chain 53 MiB db 52 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:12  Syncing   #12990 0xc309…7d95   256.05 blk/s    0.0 tx/s    0.0 Mgas/s  33231+    0 Qed    #46229   23/25 peers   5 MiB chain 56 MiB db 51 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs

❯ ./target/release/parity --chain ropsten --ports-shift 100 --no-warp
2019-01-02 15:07:17  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:07:17  Keys path /home/user/.local/share/io.parity.ethereum/keys/ropsten
2019-01-02 15:07:17  DB path /home/user/.local/share/io.parity.ethereum/chains/ropsten/db/ae90623718e47d66
2019-01-02 15:07:17  State DB configuration: fast
2019-01-02 15:07:17  Operating mode: active
2019-01-02 15:07:17  Configured for Ropsten Testnet using Ethash engine
2019-01-02 15:07:17  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30403
2019-01-02 15:07:32  Syncing     #310 0xd83a…7c8a    20.66 blk/s    1.5 tx/s    0.1 Mgas/s    212+    0 Qed      #527    2/25 peers   143 KiB chain 827 KiB db 326 KiB queue 370 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:37  Syncing    #1813 0x4a60…a6e0   300.60 blk/s    0.0 tx/s    0.0 Mgas/s    722+    0 Qed     #2540    3/25 peers   630 KiB chain 4 MiB db 1 MiB queue 494 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:42  Syncing    #3660 0xcd38…0b26   369.33 blk/s    0.6 tx/s    0.5 Mgas/s    398+    0 Qed     #4064    3/25 peers   1 MiB chain 8 MiB db 627 KiB queue 767 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:47  Syncing    #5320 0x3946…028f   331.93 blk/s    1.4 tx/s    0.2 Mgas/s    261+    0 Qed     #5588    3/25 peers   2 MiB chain 13 MiB db 419 KiB queue 776 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:52  Syncing    #6674 0x7956…6f5a   270.75 blk/s   31.4 tx/s    2.4 Mgas/s    451+    0 Qed     #7133    3/25 peers   3 MiB chain 15 MiB db 753 KiB queue 874 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:57  Syncing    #8016 0xcacc…c1f8   268.29 blk/s    3.2 tx/s    5.0 Mgas/s   1362+    0 Qed     #9384    4/25 peers   5 MiB chain 22 MiB db 3 MiB queue 1 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:02  Syncing    #9250 0xc1ae…af7f   246.60 blk/s    4.6 tx/s    3.6 Mgas/s   2434+    0 Qed    #11692    4/25 peers   6 MiB chain 24 MiB db 4 MiB queue 2 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:07  Syncing   #10521 0xeb2e…817e   253.84 blk/s   11.6 tx/s    2.9 Mgas/s   4334+    0 Qed    #14860    4/25 peers   7 MiB chain 26 MiB db 8 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:12  Syncing   #11777 0xb7b9…175c   250.90 blk/s   27.8 tx/s    6.6 Mgas/s   5981+    0 Qed    #17763    4/25 peers   7 MiB chain 28 MiB db 11 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:17  Syncing   #13039 0xb026…5e6e   256.87 blk/s   41.1 tx/s    9.2 Mgas/s   6385+    0 Qed    #19431    4/25 peers   7 MiB chain 31 MiB db 14 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:22  Syncing   #14255 0x91d6…5053   242.81 blk/s   52.3 tx/s   17.2 Mgas/s   8085+    0 Qed    #22352    4/25 peers   7 MiB chain 44 MiB db 19 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:27  Syncing   #15522 0x548f…9ede   253.25 blk/s   77.0 tx/s   29.3 Mgas/s   9238+    0 Qed    #24765    4/25 peers   7 MiB chain 48 MiB db 22 MiB queue 2 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:32  Syncing   #16771 0x4349…99ad   248.90 blk/s   97.1 tx/s   15.0 Mgas/s  10278+    0 Qed    #27052    4/25 peers   7 MiB chain 51 MiB db 25 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:37  Syncing   #17982 0x6b43…3b3d   242.51 blk/s  106.5 tx/s   15.7 Mgas/s  11859+    0 Qed    #29846    4/25 peers   7 MiB chain 54 MiB db 29 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:42  Syncing   #18884 0x8a5b…7132   179.82 blk/s  147.3 tx/s   90.4 Mgas/s  13317+  175 Qed    #32385    4/25 peers   6 MiB chain 58 MiB db 31 MiB queue 3 MiB sync  RPC:  0 conn,    0 req/s,    0 µs

❯ ./target/release/parity --chain kovan --ports-shift 200 --no-warp
2019-01-02 15:07:17  Starting Parity-Ethereum/v2.3.0-nightly-31bb556d9-20190102/x86_64-linux-gnu/rustc1.31.1
2019-01-02 15:07:17  Keys path /home/user/.local/share/io.parity.ethereum/keys/kovan
2019-01-02 15:07:17  DB path /home/user/.local/share/io.parity.ethereum/chains/kovan/db/9bf388941c25ea98
2019-01-02 15:07:17  State DB configuration: fast
2019-01-02 15:07:17  Operating mode: active
2019-01-02 15:07:17  Configured for Kovan Testnet using AuthorityRound engine
2019-01-02 15:07:17  Public node URL: enode://8dc97200ad854694b5c3ddfc9759907bcc1a7a817f750c0e80785dffab23d330428d04818e9540d2bbd9bc8294b0d2ff08b5975308418ea81d8c49c6faf091a3@192.168.1.103:30503
2019-01-02 15:07:22  Syncing    #6745 0xa707…565a  1346.65 blk/s   44.9 tx/s    4.9 Mgas/s      0+ 1481 Qed     #8232    5/25 peers   1 MiB chain 11 MiB db 2 MiB queue 6 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:27  Syncing   #18390 0x75ed…2883  2328.40 blk/s   34.0 tx/s    7.1 Mgas/s      0+ 2370 Qed    #20766    5/25 peers   6 MiB chain 41 MiB db 3 MiB queue 6 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:32  Syncing   #26566 0xe618…30bb  1623.40 blk/s    1.0 tx/s    0.3 Mgas/s      7+ 5834 Qed    #32419    4/25 peers   7 MiB chain 50 MiB db 11 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:37  Syncing   #31865 0x7cfc…9c1c  1064.61 blk/s  807.8 tx/s   18.7 Mgas/s      0+12832 Qed    #44704    5/25 peers   4 MiB chain 57 MiB db 22 MiB queue 8 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:42  Syncing   #35561 0x987c…d7a4   740.90 blk/s 1143.3 tx/s   47.9 Mgas/s      0+21044 Qed    #57150    5/25 peers   3 MiB chain 84 MiB db 30 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:47  Syncing   #42134 0xd146…8ceb  1309.61 blk/s    7.8 tx/s    0.8 Mgas/s      0+24682 Qed    #66802    5/25 peers   6 MiB chain 89 MiB db 36 MiB queue 8 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:52  Syncing   #48504 0x7124…ef37  1274.02 blk/s    4.4 tx/s    1.9 Mgas/s      0+22998 Qed    #71502    5/25 peers   6 MiB chain 90 MiB db 33 MiB queue 8 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:07:57  Syncing   #55527 0x296b…37e2  1409.20 blk/s    3.4 tx/s    0.5 Mgas/s      0+20934 Qed    #76470    5/25 peers   5 MiB chain 90 MiB db 31 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:02  Syncing   #62577 0xa849…d36a  1399.52 blk/s    0.0 tx/s    0.0 Mgas/s      0+18319 Qed    #80899    5/25 peers   5 MiB chain 89 MiB db 28 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:07  Syncing   #69000 0xbb8e…51d5  1287.46 blk/s    2.0 tx/s    0.3 Mgas/s      0+18257 Qed    #87257    5/25 peers   5 MiB chain 89 MiB db 28 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:12  Syncing   #75525 0xb5e5…1f58  1304.83 blk/s   50.9 tx/s   27.3 Mgas/s      0+16571 Qed    #92099    5/25 peers   5 MiB chain 89 MiB db 24 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:17  Syncing   #82223 0x73a0…82d8  1344.40 blk/s   34.4 tx/s   15.2 Mgas/s      0+13838 Qed    #96038    5/25 peers   5 MiB chain 88 MiB db 21 MiB queue 8 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2019-01-02 15:08:22  Syncing   #89631 0x3e8a…cb54  1456.73 blk/s    4.3 tx/s    0.6 Mgas/s      0+10309 Qed    #99949    5/25 peers   5 MiB chain 88 MiB db 16 MiB queue 7 MiB sync  RPC:  0 conn,    0 req/s,    0 µs

Waiting for full sync to finish ...

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 2, 2019
@sorpaas
Copy link
Copy Markdown
Collaborator

sorpaas commented Jan 3, 2019 •
edited
Loading

Would we mind to keep the space after :? So instead of

"name":"Kovan Testnet"

we have

"name": "Kovan Testnet"

I do think that's a more common styling convention (for example, jq by default formats json this way) and our other json files are also formatted as such.

5chdn
5chdn commented Jan 3, 2019
View reviewed changes
Comment thread ethcore/res/ethereum/ropsten.json
},
"0x000000000000000000000000000000000000000a": {
"balance": "0x0"
},
Copy link
Copy Markdown
Contributor Author

@5chdn 5chdn Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason we specify zero balance accounts? Does this even modify the state?

Copy link
Copy Markdown
Collaborator

@sorpaas sorpaas Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address is counted as "exists" from beginning (so it does modify the state).

@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Jan 3, 2019

I was using a JSON formatter. Restored the whitespaces, easier to review now.

Tbaut
Tbaut approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested on Ropsten, Kovan and Mainnet

@sorpaas

This comment has been minimized.

Sign in to view
@sorpaas

This comment has been minimized.

Sign in to view
@sorpaas

This comment has been minimized.

Sign in to view
@sorpaas
Copy link
Copy Markdown
Collaborator

sorpaas commented Jan 3, 2019

(Ah sorry I was reading diff in reverse!)

@sorpaas sorpaas added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 3, 2019
@5chdn 5chdn mentioned this pull request Jan 3, 2019
Closed
@sorpaas sorpaas merged commit 3090324 into master Jan 4, 2019
@sorpaas sorpaas deleted the a5-config-light branch January 4, 2019 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sorpaas sorpaas sorpaas approved these changes

@Tbaut Tbaut Tbaut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M2-config 📂 Chain specifications and node configurations.

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@5chdn @sorpaas @Tbaut