Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Add --frozen when running cargo#10081

Merged
ordian merged 1 commit into
openethereum:masterfrom
tomaka:frozen-build
Dec 19, 2018
Merged

Add --frozen when running cargo#10081
ordian merged 1 commit into
openethereum:masterfrom
tomaka:frozen-build

Conversation

@tomaka
Copy link
Copy Markdown
Contributor

@tomaka tomaka commented Dec 18, 2018

This detects when a PR modifies a dependency in a Cargo.toml but doesn't update the Cargo.lock.

@tomaka tomaka added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M0-build 🏗 Building and build system. M1-ci 🙉 Continuous integration. labels Dec 18, 2018
@ordian ordian merged commit c90e279 into openethereum:master Dec 19, 2018
@tomaka tomaka deleted the frozen-build branch December 19, 2018 12:51
@ordian
Copy link
Copy Markdown
Member

ordian commented Dec 25, 2018

Looks like this PR broke our CI:

Validate build
error: attempting to make an HTTP request, but --frozen was specified

I'm not sure why though, test.sh works locally for me.

tomusdrw added a commit that referenced this pull request Dec 27, 2018
@tomusdrw
Revert "Add --frozen when running cargo (#10081)"
499ae25 
This reverts commit c90e279.
ordian pushed a commit that referenced this pull request Dec 27, 2018
@tomusdrw @ordian
Revert "Add --frozen when running cargo (#10081)" (#10105)
bf9fedc 
* Revert "Add --frozen when running cargo (#10081)"

This reverts commit c90e279.

* Add Cargo.lock modification detection.
@tomaka tomaka mentioned this pull request Dec 27, 2018
Merged
@5chdn 5chdn added this to the 2.3 milestone Jan 2, 2019
@5chdn 5chdn added B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Jan 2, 2019
This was referenced Jan 2, 2019
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ordian ordian ordian approved these changes

@sorpaas sorpaas sorpaas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M0-build 🏗 Building and build system. M1-ci 🙉 Continuous integration.

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

4 participants

@tomaka @ordian @sorpaas @5chdn