whisper/cli: add p2p port and ip parameters by gballet · Pull Request #10057 · openethereum/parity-ethereum

gballet · 2018-12-12T16:31:01Z

This is so that those params don't change randomly and are in sync with the URL that
is displayed.

parity-cla-bot · 2018-12-12T16:31:06Z

It looks like @gballet hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

niklasad1

Just fix the panic that may happen on invalid IP Address which causes one test to fail. Otherwise good to go 👍

niklasad1 · 2018-12-17T09:59:20Z

Optional, rebase to master to fix cargo audit however it is fine to leave it because we squash-merge in the end!

5chdn

could you consider a minor version bump for the crate?

also, could you sign the CLA?

5chdn · 2019-01-10T12:14:54Z

Please, reopen the PR once you signed the CLA.

gballet · 2019-03-15T12:30:51Z

@5chdn @Tbaut @niklasad1 I finally got the authorization to sign the CLA 🎉 . Would you mind re-opening the PR, I don't seem to be able to.

soc1c · 2019-03-15T14:04:11Z

[clabot:check]

parity-cla-bot · 2019-03-15T14:04:13Z

It looks like @gballet hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

gballet · 2019-03-19T10:02:16Z

@niklasad1 could you have another look please?

soc1c · 2019-03-19T10:10:13Z

Can you please sign the CLA?

gballet · 2019-03-19T10:21:48Z

I just tried to sign it again, it says it's already done

soc1c · 2019-03-19T10:22:00Z

Investigating.

gballet · 2019-03-19T10:22:08Z

thanks!

ddorgan · 2019-03-19T14:42:59Z

[clabot:check]

parity-cla-bot · 2019-03-19T14:43:10Z

It looks like @gballet signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ordian · 2019-03-19T16:28:22Z

Could you update whisper/README.md as well? Looks good otherwise.

gballet · 2019-03-21T09:45:26Z

Is it possible to restart the failing builds? They failed because the build took too long.

niklasad1 · 2019-03-21T09:50:53Z

@gballet Yes, I can do it but I think the problem is the CI setup is too old.

Can you merge/rebase to master instead?

This is so that those params don't change randomly and are in sync with the URL that is displayed.

Co-Authored-By: gballet <gballet@gmail.com>

So that the enode doesn't change at every run.

Co-Authored-By: gballet <gballet@gmail.com>

gballet · 2019-03-21T14:40:06Z

Done

* master: (48 commits) ethcore: remove eth social and easthub chain configs (#10531) Initial support sccache for windows build (#10520) fix(light): make `OnDemand` generic instead of using the concrete type (#10514) private-tx: replace error_chain (#10510) Add trace information to eth_estimateGas (#10519) ethcore: add clique engine (#9981) verbose flag for cpp tests (#10524) Add a more realistic Batch test (#10511) docs: add changelogs for 2.3.{6,7,8} and 2.4.{1,2,3} (#10494) fix(rpc): fix a bunch of clippy lints (#10493) fix Sha3/keccak256 hash calculation for binaries (#10509) Add additional request tests (#10503) whisper/cli: add p2p port and ip parameters (#10057) fix(time-utils): add missing license (#10497) fix(extract `timestamp_checked_add` as lib) (#10383) fix(rpc): lint `unused_extern_crates` + fix warns (#10489) fix win&mac build (#10486) Сaching through docker volume (#10477) OpenBlock::new take IntoIterator instead of mutable ref to Iterator (#10480) simplify block module and usage (#10479) ...

Tbaut added A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations. labels Dec 12, 2018

Tbaut added this to the 2.3 milestone Dec 12, 2018

niklasad1 self-requested a review December 12, 2018 17:25

niklasad1 reviewed Dec 12, 2018

View reviewed changes

Comment thread whisper/cli/src/main.rs Outdated

niklasad1 reviewed Dec 12, 2018

View reviewed changes

Comment thread whisper/cli/src/main.rs Outdated

niklasad1 reviewed Dec 12, 2018

View reviewed changes

Comment thread whisper/cli/src/main.rs Outdated

niklasad1 suggested changes Dec 12, 2018

View reviewed changes

niklasad1 approved these changes Dec 17, 2018

View reviewed changes

niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 17, 2018

5chdn removed the A8-looksgood 🦄 Pull request is reviewed well. label Jan 2, 2019

5chdn suggested changes Jan 2, 2019

View reviewed changes

5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019

5chdn added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 10, 2019

5chdn closed this Jan 10, 2019

niklasad1 mentioned this pull request Jan 15, 2019

whisper cli: support bootnodes and devp2p port #10183

Closed

ordian reopened this Mar 15, 2019

gballet force-pushed the whisper-cli-specify-p2p branch from 317c69f to 3754ddd Compare March 18, 2019 13:06

soc1c removed the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 19, 2019

niklasad1 reviewed Mar 19, 2019

View reviewed changes

Comment thread whisper/cli/src/main.rs Outdated

ordian reviewed Mar 19, 2019

View reviewed changes

Comment thread whisper/cli/Cargo.toml Outdated

soc1c added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. labels Mar 19, 2019

soc1c modified the milestones: 2.4, 2.5 Mar 19, 2019

ordian approved these changes Mar 20, 2019

View reviewed changes

Comment thread Cargo.lock Outdated

Comment thread whisper/README.md Outdated

gballet and others added 11 commits March 21, 2019 15:16

whisper/cli: add p2p port and ip parameters

bf4b3eb

This is so that those params don't change randomly and are in sync with the URL that is displayed.

feedback: Result instead of panic

ab803e7

Co-Authored-By: gballet <gballet@gmail.com>

feedback: Map error in port conversion

95b1d9a

Co-Authored-By: gballet <gballet@gmail.com>

whisper/cli: User can specify enode private key

5480b76

So that the enode doesn't change at every run.

whipser/cli: finish integrating review feedback.

72cbf2e

Accomodate error API change

2afee32

Update rustc-hex version in whisper/cli/Cargo.toml

5cedb7b

Co-Authored-By: gballet <gballet@gmail.com>

Update README with new whisper cli options

eb3e6ef

Fix typo in error message

d802432

Co-Authored-By: gballet <gballet@gmail.com>

Fix Cargo.lock and build issue after lib version upgrade

27e0fc9

Fix another typo

2cf76ed

Co-Authored-By: gballet <gballet@gmail.com>

gballet force-pushed the whisper-cli-specify-p2p branch from 154313b to 2cf76ed Compare March 21, 2019 14:16

ordian merged commit b700ff3 into openethereum:master Mar 21, 2019

Conversation

gballet commented Dec 12, 2018

Uh oh!

parity-cla-bot commented Dec 12, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niklasad1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niklasad1 commented Dec 17, 2018

Uh oh!

5chdn left a comment

Choose a reason for hiding this comment

Uh oh!

5chdn commented Jan 10, 2019

Uh oh!

gballet commented Mar 15, 2019

Uh oh!

soc1c commented Mar 15, 2019

Uh oh!

parity-cla-bot commented Mar 15, 2019

Uh oh!

gballet commented Mar 19, 2019

Uh oh!

soc1c commented Mar 19, 2019

Uh oh!

gballet commented Mar 19, 2019

Uh oh!

soc1c commented Mar 19, 2019

Uh oh!

gballet commented Mar 19, 2019

Uh oh!

ddorgan commented Mar 19, 2019

Uh oh!

parity-cla-bot commented Mar 19, 2019

Uh oh!

Uh oh!

ordian commented Mar 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gballet commented Mar 21, 2019

Uh oh!

niklasad1 commented Mar 21, 2019

Uh oh!

gballet commented Mar 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

niklasad1 left a comment •

edited

Loading