Repository navigation
Update wordle tutorial to native vllm serve - #1082
Merged
Merged
Conversation
sergiopaniego
marked this pull request as ready for review
October 11, 2026 15:26
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the vLLM server command in
tutorial/examples/wordle.pyfrom the deprecatedtrl vllm-serveto vLLM's native server, matching the migration in huggingface/trl#6765:CUDA_VISIBLE_DEVICES=0 VLLM_SERVER_DEV_MODE=1 vllm serve Qwen/Qwen3-1.7B --host 0.0.0.0 --port 8000 \ --weight-transfer-config '{"backend": "nccl"}' \ --logprobs-mode processed_logprobs \ --max-logprobs -1TRL version
huggingface/trl#6765 shipped in TRL v1.11.0, so this command needs TRL >= 1.11.0. The tutorial's uv header installs
trl[vllm]without a version pin, so it resolves to the latest release, which includes the change.This PR was prepared with AI assistance.
Note
Low Risk
Documentation-only change to example shell commands; no runtime or training code is modified.
Overview
Updates the Wordle GRPO tutorial’s Option 2 setup so the separate vLLM server uses vLLM’s native
vllm serveinstead of the deprecatedtrl vllm-serve.The new command sets
VLLM_SERVER_DEV_MODE=1and adds flags for NCCL weight transfer,processed_logprobs, and unlimited max logprobs so the server matches TRL’s post–v1.11.0 expectations for GRPO training against a remote vLLM instance.Reviewed by Cursor Bugbot for commit 6236537. Bugbot is set up for automated code reviews on this repo. Configure here.