Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 008 slice 0: validation contracts as executable artifacts #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
RFC 008 slice 0: validation contracts as executable artifacts #1042
Changes from all commits
e79861051c6d01File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor robustness (non-blocking):
isinstance(grader, Grader)uses aruntime_checkableProtocol, which checks only attribute presence, not thatgraderis an instance vs a class. A grader authored as a class with class-levelcheck_id/level/… could pass this check and get registered un-instantiated (or the reverse). Since third-party graders load here via entry points and there's no test coveringload_entry_points,isinstance(grader, type)is a more direct "is this a class?" test, and a small entry-point-loading test in a later slice would lock the behavior down.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entry-point graders never instantiate
Medium Severity
load_entry_pointsonly calls a loaded object when it is callable and not aGrader. A class that declares the protocol fields as class attributes satisfies@runtime_checkableisinstancechecks, so it is registered as the class itself. Laterapplies_to/runcalls then bind the first argument asselfand break third-party grader loading.Reviewed by Cursor Bugbot for commit 45a86eb. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor hardening (non-blocking): if a third-party grader declares a
requires_capabilitiesfield name that isn't onCapabilitiesSpec,getattr(manifest.capabilities, field)raises a bareAttributeErrorhere rather than a clear "unknown capability field" error. Given RFC 008's "third parties add graders with zero core changes" goal, validating the field names (orgetattr(..., field, <sentinel>)with an explicit error naming the offending field/check id) would fail more helpfully.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.