Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - add .abs() in plot.py, calc_ac_loading function #319

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wheitkoetter
Copy link
Contributor

@wheitkoetter wheitkoetter commented Feb 21, 2021

Hi Clara and Ulf,

I hope you are doing well :)

Does there not have such an .abs() to be added as proposed in the commit? Because the average shall be calculated over both negative and positive flows. In line 1158 at the calculation for q0 there is also such an .abs() included: mul_weighting(network, network.lines_t.q0).loc[network.snapshots[timesteps]].abs().sum()

Or am I wrong?

Cheers Wilko

@ClaraBuettner
Copy link
Contributor

Hi Wilko,
sorry for my late reply. I hope you are also doing well!
I think both options are reasonable. I often used this function to visualize transfer flows between different buses, therefore I had to sum up negative and positive values. When you want to see the mean loading of the line e.g. to see how often it is used, the absolute values have to be summed up. But it is definitely wrong to do it differently for active and reactive power.
I would suggest to have both options; 'line_loading' (with .abs()) and 'line_flows' (without abs()). The arrows on the lines would be used only in the 'line_flows' plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants