bugfix - add .abs() in plot.py, calc_ac_loading function #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Clara and Ulf,
I hope you are doing well :)
Does there not have such an .abs() to be added as proposed in the commit? Because the average shall be calculated over both negative and positive flows. In line 1158 at the calculation for q0 there is also such an .abs() included: mul_weighting(network, network.lines_t.q0).loc[network.snapshots[timesteps]].abs().sum()
Or am I wrong?
Cheers Wilko