Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created EEWeatherWarning #26

Merged
merged 6 commits into from
Aug 21, 2018
Merged

created EEWeatherWarning #26

merged 6 commits into from
Aug 21, 2018

Conversation

ssuffian
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     27    +2     
  Lines        2420   2453   +33     
=====================================
+ Hits         2420   2453   +33
Impacted Files Coverage Δ
eeweather/ranking.py 100% <100%> (ø) ⬆️
tests/test_warnings.py 100% <100%> (ø)
eeweather/__version__.py 100% <100%> (ø) ⬆️
tests/test_ranking.py 100% <100%> (ø) ⬆️
eeweather/warnings.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47be312...b0005b3. Read the comment docs.

@philngo
Copy link
Contributor

philngo commented Aug 20, 2018

Looks good to me. Maybe put the warnings into a new warnings.py file instead of utils.py? I think of utils.py as a miscellaneous module, so the less we can put in there the better in terms of clarity for newcomers.

@ssuffian ssuffian merged commit e04978a into master Aug 21, 2018
@ssuffian ssuffian deleted the feature/make_real_warnings branch August 21, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants