Skip to content

feat: skill verification pipeline #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navinkarkera merged 15 commits into from
Jan 5, 2023
Merged

feat: skill verification pipeline #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
05f6643
feat: implement pipeline skeleton
navinkarkera Dec 27, 2022
c6d8830
feat: first working implementation
navinkarkera Dec 28, 2022
3610d55
refactor: simplify mixin and implement check for pipeline
navinkarkera Dec 29, 2022
462cb7f
fix: make skill chips accessible
navinkarkera Dec 30, 2022
e148793
refactor: fix formatting
navinkarkera Dec 30, 2022
5f7781c
feat: add option to configure probability of displaying the form
navinkarkera Dec 30, 2022
cb1e275
fix: mixin tests
navinkarkera Dec 30, 2022
c9f0b5d
fix: tests and lint setup
navinkarkera Dec 30, 2022
fb66c22
refactor: tests for pipeline
navinkarkera Dec 30, 2022
a6b15b9
fix: image styling in small screen
navinkarkera Dec 30, 2022
3a85740
fix: tox workbench test
navinkarkera Dec 30, 2022
67d16d6
refactor: move skills check and rename variable
navinkarkera Jan 3, 2023
0488147
refactor: disable submit button till input is filled
navinkarkera Jan 4, 2023
88ddc16
refactor: better readCookie function
navinkarkera Jan 4, 2023
d3d5975
refactor: remove unnecessary alert and add todo in requirements file
navinkarkera Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,18 @@ piptools: ## install pinned version of pip-compile and pip-sync
requirements: piptools ## install development environment requirements
pip-sync -q requirements/dev.txt requirements/private.*

test: ## Run the tests
test: clean ## run tests in the current virtualenv
mkdir -p var
rm -rf .coverage
python -m coverage run --rcfile=.coveragerc ./test.py --noinput
DJANGO_SETTINGS_MODULE=test_settings pytest

diff_cover: test ## find diff lines that need test coverage
diff-cover coverage.xml

test-all: quality pii_check ## run tests on every supported Python/Django combination
test-all: quality ## run tests on every supported Python/Django combination
tox
tox -e docs

validate: quality pii_check test ## run tests and quality checks
validate: quality test ## run tests and quality checks

selfcheck: ## check that the Makefile is well-formed
@echo "The Makefile is well-formed."
Expand Down
9 changes: 4 additions & 5 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ Purpose

Django app plugin for fetching and verifying tags for xblock skills.

TODO: The ``README.rst`` file should start with a brief description of the repository and its purpose.
It should be described in the context of other repositories under the ``openedx``
organization. It should make clear where this fits in to the overall Open edX
codebase and should be oriented towards people who are new to the Open edX
project.
Set ``SHOW_SKILL_VERIFICATION_PROBABILITY`` in your django settings to configure
probability of displaying verification form. Values in range 0 to 1 are
allowed, where 0 means never and 1 means always display. Default value is 0.5
i.e. 50% chance of displaying the form.

Getting Started
***************
Expand Down
2 changes: 2 additions & 0 deletions requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@

Django # Web application framework
django-model-utils # Provides TimeStampedModel abstract base class
# TODO: update below dependencies when its commits are merged to upstream
git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba#egg=openedx_events
git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe#egg=openedx-filters
Comment thread
navinkarkera marked this conversation as resolved.
3 changes: 3 additions & 0 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ django==3.2.16
# -r requirements/base.in
# django-model-utils
# openedx-events
# openedx-filters
django-model-utils==4.3.1
# via -r requirements/base.in
edx-opaque-keys[django]==2.3.0
Expand All @@ -22,6 +23,8 @@ fastavro==1.7.0
# via openedx-events
openedx_events @ git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba
# via -r requirements/base.in
openedx-filters @ git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe
# via -r requirements/base.in
pbr==5.11.0
# via stevedore
pymongo==3.13.0
Expand Down
6 changes: 3 additions & 3 deletions requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@ charset-normalizer==2.1.1
# via requests
codecov==2.1.12
# via -r requirements/ci.in
coverage==7.0.0
coverage==7.0.1
# via codecov
distlib==0.3.6
# via virtualenv
filelock==3.8.2
filelock==3.9.0
# via
# tox
# virtualenv
idna==3.4
# via requests
packaging==22.0
# via tox
platformdirs==2.6.0
platformdirs==2.6.2
# via virtualenv
pluggy==1.0.0
# via tox
Expand Down
17 changes: 10 additions & 7 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ boto==2.49.0
# via
# -r requirements/quality.txt
# xblock-sdk
boto3==1.26.35
boto3==1.26.40
# via
# -r requirements/quality.txt
# fs-s3fs
botocore==1.29.35
botocore==1.29.40
# via
# -r requirements/quality.txt
# boto3
Expand Down Expand Up @@ -85,7 +85,7 @@ cookiecutter==2.1.1
# via
# -r requirements/quality.txt
# xblock-sdk
coverage[toml]==7.0.0
coverage[toml]==7.0.1
# via
# -r requirements/ci.txt
# -r requirements/quality.txt
Expand All @@ -110,6 +110,7 @@ django==3.2.16
# djangorestframework
# edx-i18n-tools
# openedx-events
# openedx-filters
# xblock-sdk
django-model-utils==4.3.1
# via -r requirements/quality.txt
Expand All @@ -127,15 +128,15 @@ edx-opaque-keys[django]==2.3.0
# via
# -r requirements/quality.txt
# openedx-events
exceptiongroup==1.0.4
exceptiongroup==1.1.0
# via
# -r requirements/quality.txt
# pytest
fastavro==1.7.0
# via
# -r requirements/quality.txt
# openedx-events
filelock==3.8.2
filelock==3.9.0
# via
# -r requirements/ci.txt
# tox
Expand Down Expand Up @@ -202,10 +203,12 @@ mccabe==0.7.0
# via
# -r requirements/quality.txt
# pylint
mock==4.0.3
mock==5.0.0
# via -r requirements/quality.txt
openedx_events @ git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba
# via -r requirements/quality.txt
openedx-filters @ git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe
# via -r requirements/quality.txt
packaging==22.0
# via
# -r requirements/ci.txt
Expand All @@ -226,7 +229,7 @@ pep517==0.13.0
# build
pip-tools==6.12.1
# via -r requirements/pip-tools.txt
platformdirs==2.6.0
platformdirs==2.6.2
# via
# -r requirements/ci.txt
# -r requirements/quality.txt
Expand Down
19 changes: 11 additions & 8 deletions requirements/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ boto==2.49.0
# via
# -r requirements/test.txt
# xblock-sdk
boto3==1.26.35
boto3==1.26.40
# via
# -r requirements/test.txt
# fs-s3fs
botocore==1.29.35
botocore==1.29.40
# via
# -r requirements/test.txt
# boto3
Expand Down Expand Up @@ -73,7 +73,7 @@ cookiecutter==2.1.1
# via
# -r requirements/test.txt
# xblock-sdk
coverage[toml]==7.0.0
coverage[toml]==7.0.1
# via
# -r requirements/test.txt
# pytest-cov
Expand All @@ -87,6 +87,7 @@ django==3.2.16
# django-pyfs
# djangorestframework
# openedx-events
# openedx-filters
# xblock-sdk
django-model-utils==4.3.1
# via -r requirements/test.txt
Expand All @@ -96,7 +97,7 @@ django-pyfs==3.2.0
# xblock-sdk
djangorestframework==3.14.0
# via -r requirements/test.txt
doc8==1.0.0
doc8==1.1.1
# via -r requirements/doc.in
docutils==0.19
# via
Expand All @@ -108,7 +109,7 @@ edx-opaque-keys[django]==2.3.0
# via
# -r requirements/test.txt
# openedx-events
exceptiongroup==1.0.4
exceptiongroup==1.1.0
# via
# -r requirements/test.txt
# pytest
Expand Down Expand Up @@ -138,7 +139,7 @@ importlib-metadata==5.2.0
# keyring
# sphinx
# twine
importlib-resources==5.10.1
importlib-resources==5.10.2
# via keyring
iniconfig==1.1.1
# via
Expand Down Expand Up @@ -182,12 +183,14 @@ markupsafe==2.1.1
# -r requirements/test.txt
# jinja2
# xblock
mock==4.0.3
mock==5.0.0
# via -r requirements/test.txt
more-itertools==9.0.0
# via jaraco-classes
openedx_events @ git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba
# via -r requirements/test.txt
openedx-filters @ git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe
# via -r requirements/test.txt
packaging==22.0
# via
# -r requirements/test.txt
Expand Down Expand Up @@ -292,7 +295,7 @@ six==1.16.0
# python-dateutil
snowballstemmer==2.2.0
# via sphinx
sphinx==5.3.0
sphinx==6.0.0
# via -r requirements/doc.in
sphinxcontrib-applehelp==1.0.2
# via sphinx
Expand Down
15 changes: 9 additions & 6 deletions requirements/quality.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ boto==2.49.0
# via
# -r requirements/test.txt
# xblock-sdk
boto3==1.26.35
boto3==1.26.40
# via
# -r requirements/test.txt
# fs-s3fs
botocore==1.29.35
botocore==1.29.40
# via
# -r requirements/test.txt
# boto3
Expand Down Expand Up @@ -71,7 +71,7 @@ cookiecutter==2.1.1
# via
# -r requirements/test.txt
# xblock-sdk
coverage[toml]==7.0.0
coverage[toml]==7.0.1
# via
# -r requirements/test.txt
# pytest-cov
Expand All @@ -85,6 +85,7 @@ django==3.2.16
# django-pyfs
# djangorestframework
# openedx-events
# openedx-filters
# xblock-sdk
django-model-utils==4.3.1
# via -r requirements/test.txt
Expand All @@ -100,7 +101,7 @@ edx-opaque-keys[django]==2.3.0
# via
# -r requirements/test.txt
# openedx-events
exceptiongroup==1.0.4
exceptiongroup==1.1.0
# via
# -r requirements/test.txt
# pytest
Expand Down Expand Up @@ -164,10 +165,12 @@ markupsafe==2.1.1
# xblock
mccabe==0.7.0
# via pylint
mock==4.0.3
mock==5.0.0
# via -r requirements/test.txt
openedx_events @ git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba
# via -r requirements/test.txt
openedx-filters @ git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe
# via -r requirements/test.txt
packaging==22.0
# via
# -r requirements/test.txt
Expand All @@ -176,7 +179,7 @@ pbr==5.11.0
# via
# -r requirements/test.txt
# stevedore
platformdirs==2.6.0
platformdirs==2.6.2
# via pylint
pluggy==1.0.0
# via
Expand Down
13 changes: 8 additions & 5 deletions requirements/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ binaryornot==0.4.4
# via cookiecutter
boto==2.49.0
# via xblock-sdk
boto3==1.26.35
boto3==1.26.40
# via fs-s3fs
botocore==1.29.35
botocore==1.29.40
# via
# boto3
# s3transfer
Expand All @@ -41,7 +41,7 @@ code-annotations==1.3.0
# via -r requirements/test.in
cookiecutter==2.1.1
# via xblock-sdk
coverage[toml]==7.0.0
coverage[toml]==7.0.1
# via pytest-cov
# via
# -c https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt
Expand All @@ -50,6 +50,7 @@ coverage[toml]==7.0.0
# django-pyfs
# djangorestframework
# openedx-events
# openedx-filters
# xblock-sdk
django-model-utils==4.3.1
# via -r requirements/base.txt
Expand All @@ -61,7 +62,7 @@ edx-opaque-keys[django]==2.3.0
# via
# -r requirements/base.txt
# openedx-events
exceptiongroup==1.0.4
exceptiongroup==1.1.0
# via pytest
fastavro==1.7.0
# via
Expand Down Expand Up @@ -101,10 +102,12 @@ markupsafe==2.1.1
# via
# jinja2
# xblock
mock==4.0.3
mock==5.0.0
# via -r requirements/test.in
openedx_events @ git+https://github.com/open-craft/openedx-events.git@77ad965c4ac5157b861a19b8cb6b9240883008ba
# via -r requirements/base.txt
openedx-filters @ git+https://github.com/open-craft/openedx-filters.git@d0206cf84f2e5e22b1a99d06566d88839d40b9fe
# via -r requirements/base.txt
packaging==22.0
# via pytest
pbr==5.11.0
Expand Down
Loading