Skip to content

[BD-13][BB-6927] Rename descriptor to block - #322

Closed
pkulkark wants to merge 2 commits into
openedx:masterfrom
open-craft:pooja/rename-descriptor-to-block
Closed

[BD-13][BB-6927] Rename descriptor to block#322
pkulkark wants to merge 2 commits into
openedx:masterfrom
open-craft:pooja/rename-descriptor-to-block

Conversation

@pkulkark

@pkulkark pkulkark commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Description

descriptor was renamed to block in openedx/openedx-platform#31492. This PR updates the corresponding imports.

Testing Instructions

This must be tested along with openedx/openedx-platform#31492.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jan 6, 2023
@openedx-webhooks

openedx-webhooks commented Jan 6, 2023

Copy link
Copy Markdown

Thanks for the pull request, @pkulkark!

When this pull request is ready, tag your edX technical lead.

@pkulkark pkulkark changed the title [BD-13][BB-6927] Rename descriptor to block [WIP][BD-13][BB-6927] Rename descriptor to block Jan 6, 2023
@codecov

codecov Bot commented Jan 6, 2023

Copy link
Copy Markdown

Codecov Report

Base: 97.68% // Head: 97.68% // No change to project coverage 👍

Coverage data is based on head (f55bba9) compared to base (f3eca6b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          75       75           
  Lines        6090     6090           
=======================================
  Hits         5949     5949           
  Misses        141      141           
Flag Coverage Δ
unittests 97.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lti_consumer/plugin/compat.py 60.00% <ø> (ø)
lti_consumer/lti_xblock.py 96.30% <100.00%> (ø)
lti_consumer/tests/unit/test_lti_xblock.py 99.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pkulkark pkulkark changed the title [WIP][BD-13][BB-6927] Rename descriptor to block [BD-13][BB-6927] Rename descriptor to block Jan 9, 2023
@Agrendalath

Copy link
Copy Markdown
Member

We reverted this rename from the upstream PR. Closing.

@Agrendalath
Agrendalath deleted the pooja/rename-descriptor-to-block branch April 26, 2023 15:24
@openedx-webhooks

Copy link
Copy Markdown

@pkulkark Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants