Skip to content

[BD-13][BB-6926] refactor: fix module-containing imports - #320

Merged
Agrendalath merged 1 commit into
openedx:masterfrom
open-craft:0x29a/bb6926/rename_module_to_block
Jan 30, 2023
Merged

[BD-13][BB-6926] refactor: fix module-containing imports#320
Agrendalath merged 1 commit into
openedx:masterfrom
open-craft:0x29a/bb6926/rename_module_to_block

Conversation

@0x29a

@0x29a 0x29a commented Dec 25, 2022

Copy link
Copy Markdown
Contributor

Description

module_render and get_module_for_descriptor_internal were renamed in openedx/openedx-platform#31475. This PR fixes imports.

Testing instructions

See the testing instructions for openedx/openedx-platform#31475

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Dec 25, 2022
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @0x29a!

When this pull request is ready, tag your edX technical lead.

@codecov

codecov Bot commented Dec 25, 2022

Copy link
Copy Markdown

Codecov Report

Base: 97.66% // Head: 97.66% // No change to project coverage 👍

Coverage data is based on head (17d93c0) compared to base (390de4c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          76       76           
  Lines        6129     6129           
=======================================
  Hits         5986     5986           
  Misses        143      143           
Flag Coverage Δ
unittests 97.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lti_consumer/lti_xblock.py 96.30% <ø> (ø)
lti_consumer/plugin/compat.py 60.00% <ø> (ø)
lti_consumer/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Agrendalath
Agrendalath force-pushed the 0x29a/bb6926/rename_module_to_block branch from e0b6436 to 17d93c0 Compare January 30, 2023 17:06

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested this along with openedx/openedx-platform#31475
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath
Agrendalath merged commit c24aebc into openedx:master Jan 30, 2023
@openedx-webhooks

Copy link
Copy Markdown

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath
Agrendalath deleted the 0x29a/bb6926/rename_module_to_block branch January 30, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants