Skip to content

refactor: replace usages of get_real_user and course_id [BD-13] - #291

Closed
xitij2000 wants to merge 3 commits into
masterfrom
kshitij/replace-deprecated-attributes
Closed

refactor: replace usages of get_real_user and course_id [BD-13]#291
xitij2000 wants to merge 3 commits into
masterfrom
kshitij/replace-deprecated-attributes

Conversation

@xitij2000

@xitij2000 xitij2000 commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Replaces usages of get_real_user with the UserService and course_id with runtime.scope_ids.usage_id.context_key

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 5, 2022
@openedx-webhooks

openedx-webhooks commented Oct 5, 2022

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

When this pull request is ready, tag your edX technical lead.

@xitij2000
xitij2000 force-pushed the kshitij/replace-deprecated-attributes branch from 04a090d to 81bdfae Compare October 5, 2022 12:35
Replaces usages of runtime.course_id with runtime.scope_ids.usage_id.context_key.
@xitij2000
xitij2000 force-pushed the kshitij/replace-deprecated-attributes branch from 81bdfae to 46e2fcc Compare October 6, 2022 02:35
@codecov

codecov Bot commented Oct 6, 2022

Copy link
Copy Markdown

Codecov Report

Base: 96.65% // Head: 96.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (11fe1ae) compared to base (bc81d49).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files          68       68           
  Lines        5237     5238    +1     
=======================================
+ Hits         5062     5063    +1     
  Misses        175      175           
Flag Coverage Δ
unittests 96.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lti_consumer/lti_xblock.py 94.40% <100.00%> (ø)
lti_consumer/outcomes.py 100.00% <100.00%> (ø)
lti_consumer/tests/unit/test_lti_xblock.py 98.96% <100.00%> (ø)
lti_consumer/tests/unit/test_outcomes.py 100.00% <100.00%> (ø)
lti_consumer/tests/unit/test_utils.py 97.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xitij2000
xitij2000 marked this pull request as ready for review October 6, 2022 11:26
@xitij2000 xitij2000 changed the title refactor: replace usage of get_real_user with UserService [BD-13] refactor: replace usages of get_real_user and course_id [BD-13] Oct 6, 2022
@giovannicimolin

Copy link
Copy Markdown
Contributor

@xitij2000 I can review this one, can you rebase and fix the conflicts? I can review and test.
Also, is there any risk for the discussions LTI integrations with this change?

@Agrendalath

Copy link
Copy Markdown
Member

Closing, as we included this in #249.

@openedx-webhooks

Copy link
Copy Markdown

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath
Agrendalath deleted the kshitij/replace-deprecated-attributes branch November 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants